Henrik Andersson
41b8e1ce06
Merge pull request #160 from derfian/remove-make-proto
...
Remove infrastructure to auto-generate proto.h
2017-10-06 10:35:36 +02:00
Henrik Andersson
b37122330a
Merge pull request #159 from derfian/audio-refactoring-to-spec
...
Audio refactoring to spec
2017-10-06 10:35:05 +02:00
Henrik Andersson
df038988b6
Merge pull request #162 from uglym8/fix_osx_build
...
Fix osx build
2017-10-06 09:40:09 +02:00
Alexander Zakharov
ed3726a9fa
Handle the lack of SCARD_CTL_CODE on Mac
2017-10-05 19:47:59 +03:00
Alexander Zakharov
f091a38cff
Sane way to fix absence of HOST_NAME_MAX on osx
2017-10-05 19:47:50 +03:00
Alexander Zakharov
b71d79cdb1
Add support for Kerberos on Mac
2017-10-05 19:45:03 +03:00
Karl Mikaelsson
1f13c85583
Remove infrastructure to auto-generate proto.h
...
If proto.h is supposed to be auto-generated it should probably not be
present in the repo at all. Re-running cproto showed that proto.h has
been manually edited for quite some time, so this just makes this the
only workflow.
It also gets rid of a bit of #ifdefs, so that's nice.
2017-10-05 15:18:13 +02:00
Karl Mikaelsson
8316b346e8
Remove accidental packsize reference
...
This was work done on another branch that got included here by
mistake.
2017-10-05 15:02:01 +02:00
Karl Mikaelsson
e48f947794
Include selected sound driver in the verbose output
...
This could be somewhat useful for troubleshooting audio, so burying it
in the debug log output is unhelpful.
2017-10-05 14:41:25 +02:00
Karl Mikaelsson
329289ff6c
Don't log an error on new audio format handshakes
...
This happens regularly and it's not an error. An easy way to trigger
this scenario is to let cmd.exe produce a bell sound by tab-completing
something non-existant.
2017-10-05 14:41:25 +02:00
Karl Mikaelsson
7870ef6f86
Refactor rdpsnd to follow to the MS-RDPEA specs more closely
...
Rename functions and change the constants to match the specification.
2017-10-05 14:41:25 +02:00
Henrik Andersson
db8b56db44
Merge pull request #156 from derfian/smart-card-logging
...
Don't log common Smart Card error codes as rdesktop errors
2017-10-05 10:55:30 +02:00
Henrik Andersson
12b28b83d7
Merge pull request #155 from samhed/disconnectreasons
...
Handle more disconnect reasons
2017-10-05 10:53:43 +02:00
Samuel Mannehed
b89a5899f0
Update man-page with new return codes/texts
2017-10-05 10:45:54 +02:00
Henrik Andersson
0a3a6fbca8
Merge pull request #154 from derfian/fix-disk-logging
...
Move logging code to after variable declarations
2017-10-05 07:19:55 +02:00
Karl Mikaelsson
dca441c4e6
Don't log warnings/errors from TS_SCardGetStatusChange at all
...
Not sure why I thought the user needed to see this at all.
2017-10-04 17:11:02 +02:00
Samuel Mannehed
b0813fa275
Add handling for a few special RDP error codes
...
Most of the RPD protocol errors (reason > 0x1000) would only be
triggered by coding errors in the client. A few of them can occur due
to server errors however. We should attempt to handle these cases.
2017-10-04 16:27:34 +02:00
Samuel Mannehed
e8562507e7
Add handling for connection broker error codes
2017-10-04 15:51:36 +02:00
Samuel Mannehed
e272feaa8a
Print the reason code for protocol errors
2017-10-04 15:50:49 +02:00
Karl Mikaelsson
96faa24bd5
Don't log common Smart Card error codes as rdesktop errors
...
The proper thing to do would be to forward the errors to the server
and let it deal with it. No need to present these as errors to the
user.
2017-10-04 15:20:46 +02:00
Samuel Mannehed
2e744bf54f
Indent rdesktop exit codes
2017-10-04 13:21:57 +02:00
Samuel Mannehed
dfad103fd9
Tweak wording of disconnect reason messages
...
They are now a bit more specific and better match the description of
the disconnection reasons sent by the server.
2017-10-04 12:36:59 +02:00
Samuel Mannehed
3aca74880a
Fix specific admin/user disconnect/logout codes
...
There seems to have been confusion with regards to which exit code and
message was returned by rdesktop for the following cases:
* disconnected by admin
* logged out by admin
* disconnect by user
* logoff by user
Looking at Microsoft's official documentation as well as testing using
Windows Server 2008 R2, 2012 R2 and 2016 reveals that this commit fixes
this issue. They do now match the reasons sent by the server.
2017-10-04 12:32:42 +02:00
Samuel Mannehed
a6a2120cf7
Rename constants for disconnect reasons
...
To make them easier to search for - let's match the names with the
corresponding names on the server side:
https://msdn.microsoft.com/en-us/library/cc240544.aspx
2017-10-04 09:35:14 +02:00
Karl Mikaelsson
1a026814a5
Move logging code to after variable declarations
2017-10-03 11:07:32 +02:00
Henrik Andersson
594438e5eb
Make deprecated rdp_out_unistr() static
2017-09-29 16:30:17 +02:00
Henrik Andersson
ff1a42f809
Refactor of writing utf16 strings to packets.
...
This remove the use of deprecated rdp_out_unistr() and
uses correct string length instead of assumition that all
utf16 symbols are represented by 2 bytes.
2017-09-29 16:30:17 +02:00
Henrik Andersson
995e830665
Use new out_utf16s_padded() string function for fixed string
2017-09-29 16:30:17 +02:00
Henrik Andersson
791906e45d
Add function to write fixed length utf16 string to stream
2017-09-29 16:30:17 +02:00
Henrik Andersson
e195953496
Refactor of writing utf16 strings to packets.
...
This remove the use of deprecated rdp_out_unistr() and
some minor cleanups.
2017-09-29 16:30:17 +02:00
Henrik Andersson
e35a76bce2
Refactor writing of utf16 strings into packets
...
The old code was filled by assumtions that all symbols in utf16
is represented by 2 bytes which is not true and resulted in
truncated strings.
Fixes issue #60
2017-09-29 14:25:41 +02:00
Henrik Andersson
de8fe9429f
Add two new stream functions for writing utf16 strings
...
This is the first steps of removing the old rdp_out_unistr() and
using clearer code.
2017-09-29 14:24:27 +02:00
Henrik Andersson
b8fe3e9315
Rename parse to stream
2017-09-29 11:13:02 +02:00
Henrik Andersson
fc6ce03875
Make use of shared stream api
...
Remove own componized realloc and reset code to
shared stream api implementation.
2017-09-28 19:15:00 +02:00
Henrik Andersson
4cbfda90fd
Move static stream helper functions to parse.c
2017-09-28 19:12:11 +02:00
Henrik Andersson
0954ac3ca5
Some cursors are hard to see on dark background
...
The new cursor rendering code that was added will render
1bpp XOR cursors as plain black cursors. This introduces
a problem were the cursor is not visible on dark backgrounds.
This change adds a white outlined rendering of the shape to
those specific cursors.
2017-09-27 13:49:33 +02:00
Henrik Andersson
96cf016028
Add sound backend dependencies
...
to get a bigger compile coverage
2017-09-26 16:26:04 +02:00
Henrik Andersson
8cb4149722
Use correct log message level for rdpsnd_process()
2017-09-26 15:04:58 +02:00
Henrik Andersson
cb6460788c
Remove unused variable
2017-09-26 13:58:56 +02:00
Henrik Andersson
04761c66c6
Free image after cursor is created.
2017-09-26 11:13:09 +02:00
Henrik Andersson
550056ab42
Add debug log for ui_set_cursor()
2017-09-26 09:16:43 +02:00
Henrik Andersson
01beda5b45
Ran indent script
2017-09-26 09:03:20 +02:00
Henrik Andersson
109893c9da
Fix type in log message
2017-09-26 09:02:32 +02:00
Henrik Andersson
17fa29c783
Merge pull request #150 from derfian/disk-logging
...
Disk debug logging
2017-09-23 10:13:17 +02:00
Karl Mikaelsson
e3993a6c0d
Add more Disk debug logging
...
A log entry for (almost) every disk operation.
2017-09-22 14:54:36 +02:00
Karl Mikaelsson
a545281d72
Switch disk log subject from Core/Protocol to Disk
2017-09-22 14:54:36 +02:00
Karl Mikaelsson
588329db6e
Add a new Disk log subject
...
Most of the disk access used to be bunched together with the general
protocol debugging, which made it hard to isolate log messages from
the disk subsystem. This commit introduces a new "Disk" log subject.
2017-09-22 14:54:36 +02:00
Henrik Andersson
9d0a4ec100
Add slack integration
2017-09-21 19:31:19 +02:00
Henrik Andersson
1e3e8ee19a
Add build dependency for libxcursor
2017-09-21 16:29:07 +02:00
Henrik Andersson
6dd85edc6f
Rewrite cursor code to use Xcursor
...
This commit enables support for color cursors with alpha,
however this raises the requirement of libXcursor which is
not such a big deal.
Fixes issue #86 and #21
2017-09-21 16:02:56 +02:00