Commit Graph

85 Commits

Author SHA1 Message Date
Henrik Andersson
0d707ae103 Fix sign-compare compiler warnings 2017-10-20 13:30:42 +02:00
Henrik Andersson
fd1673392e Fix unused-but-set-variable compiler warnings 2017-10-17 10:50:14 +02:00
Henrik Andersson
ff1a42f809 Refactor of writing utf16 strings to packets.
This remove the use of deprecated rdp_out_unistr() and
uses correct string length instead of assumition that all
utf16 symbols are represented by 2 bytes.
2017-09-29 16:30:17 +02:00
Henrik Andersson
1e68d67298 Run indent-all script 2017-03-03 09:31:26 +01:00
Henrik Andersson
d124477abb Merge pull request #96 from derfian/decipher-rdpdr-printer-device-announce
Clarify printer parts of rdpdr_send_client_device_list_announce
2017-01-30 10:05:02 +01:00
Karl Mikaelsson
7f6748d1c3 Clarify printer parts of rdpdr_send_client_device_list_announce
Add new flag constants and comments for all fields.
2017-01-30 09:35:29 +01:00
Henrik Andersson
7b9a09e173 Merge branch 'master' into logging 2017-01-27 10:56:16 +01:00
Henrik Andersson
87d8d123b8 Rework the logging system
This commit will add a logging system to solve the problem that
one actually need to recompile rdesktop from source to enable
different debug logging.

- Same logging api  for all kind of logging and messages to
   end user.

- Adding -v for verbose output when running rdesktop.

- All messages are logged into a subject and with a type, eg:

     logger(Keyboard, Notice, "Autos-electing %s based on locale.", locale);

- Debug logging is enabled trough a environment variable RDEKSTOP_DEBUG,
  which specifies subjects of interest, comma separated. There is a special
  subject named All which includes all subject for debug loggin. There is also
  a simple logic opeartor '!' = NOT which can be used in combination like:

    RDESKTOP_DEBUG=All,!Graphics,!Sound

  Which would give debug log output for All subject except Graphics and Sound.
2017-01-26 14:19:40 +01:00
Karl Mikaelsson
90ea473750 Send longer drive names for redirected drives
Store the full drive name in a new disk-specific pdevice_data
struct. Bump Drive Redirection version to 02, and send the full name
as part of the Device Announcement message.
2017-01-25 13:27:01 +01:00
Karl Mikaelsson
b093dc198d Decipher the contents of the DR_CORE_CAPABILITY_RSP message
Add relevant constants from the specification and use them while
building the capabilities reply.
2017-01-20 16:05:59 +01:00
Henrik Andersson
761cc053e2 Fixes a bug with Windows Server 2012 r2 and smartcard
redirection were the RDPDR channel is shutdown by server.

The RDPDR channel is shutdown by server when responses from
abdonend iorequests are received on a reinitialized RDPDR
channel. This fix adds epochs for RDPDR channel and tags 
iorequest to specific epoch to handle abdonend iorequest.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1836 423420c4-83ab-492f-b58f-81f9feb106b5
2014-09-11 11:54:46 +00:00
Henrik Andersson
03c53c48bd Fix implementation of DR_CORE_CLIENT_NAME_REQ packet.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1834 423420c4-83ab-492f-b58f-81f9feb106b5
2014-09-11 08:58:40 +00:00
Henrik Andersson
ae54605c8d - Clarification of client and server announce
- Make sure to use server supplied ClientID if
  server VersionMinor is >= 12.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1833 423420c4-83ab-492f-b58f-81f9feb106b5
2014-09-11 08:54:31 +00:00
Henrik Andersson
388cec747d - Clarification of code.
- Make sure to send DR_CORE_CAPABILITY_RSP as response
  to DR_CORE_SERVER_ANNOUNCE_REQ.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1832 423420c4-83ab-492f-b58f-81f9feb106b5
2014-09-11 08:38:27 +00:00
Henrik Andersson
0858a6c9a7 Clarify implementation to match MS-RDPEFS spec.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1831 423420c4-83ab-492f-b58f-81f9feb106b5
2014-09-11 08:19:23 +00:00
Henrik Andersson
ace6c10a5b Remove dead code.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1830 423420c4-83ab-492f-b58f-81f9feb106b5
2014-09-11 07:50:48 +00:00
Henrik Andersson
0440d0faca Make use of constants defined in specification instead of
magic character numbers found in protocol stream for clarity.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1828 423420c4-83ab-492f-b58f-81f9feb106b5
2014-09-09 12:34:09 +00:00
Henrik Andersson
7ece007132 Fix indentation...
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1778 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-12 14:01:58 +00:00
Henrik Andersson
013ac6d541 Make sure to check agains null pointer in disk_create()
Simplified FileRenameInformation in disk_set_information()
and handle error if newname is null.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1775 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-06 13:52:29 +00:00
Henrik Andersson
f0b6604347 Changed rdp_in_unistr() to make dynamic allocation of converted string
instead of using hardcoded buffer sizes and assumtion that conversion
just fits the size.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1773 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-06 12:43:08 +00:00
Henrik Andersson
2e1dca75f8 Fix indentation.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1702 423420c4-83ab-492f-b58f-81f9feb106b5
2013-03-22 10:20:11 +00:00
Henrik Andersson
5b1e084fe2 Fix crash when a invalid device is received in rdpdr_process_irp.
Thanks goes to David Fries for the patch.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1701 423420c4-83ab-492f-b58f-81f9feb106b5
2013-03-22 10:17:11 +00:00
Henrik Andersson
81641e5b4d Fixes a memoryleak in rdpdr_process_irp upon error.
Thansk goes to David Fries for patches.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1700 423420c4-83ab-492f-b58f-81f9feb106b5
2013-03-22 10:11:00 +00:00
Peter Åstrand
b638882347 Include emails in copyright statements.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1615 423420c4-83ab-492f-b58f-81f9feb106b5
2011-04-13 11:13:04 +00:00
Peter Åstrand
27068f53f8 Updated the copyright notices for the things we have been working on.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1612 423420c4-83ab-492f-b58f-81f9feb106b5
2011-04-13 08:55:42 +00:00
Henrik Andersson
161b4f215a - Remove force flag from rdpdr_init()
- Changes to always start the rdpdr channel
  due assumtions that this channel is supposed
  to always be up and running.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1607 423420c4-83ab-492f-b58f-81f9feb106b5
2011-01-03 13:12:17 +00:00
Henrik Andersson
9dd6bdab95 Fix for sound playback in Windows 2008R2 which requires
the rdpdr channel to be initiated. 
RDPEA nor RDPBCGR mention a relation between audio and
the rdpdr channel.

See. support request #2717082



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1604 423420c4-83ab-492f-b58f-81f9feb106b5
2010-12-20 13:42:51 +00:00
Henrik Andersson
64e4fa886a Cleanup of previous commit that introduced
unrelated changes into commit by mistake.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1603 423420c4-83ab-492f-b58f-81f9feb106b5
2010-12-20 13:14:25 +00:00
Henrik Andersson
7dc38dcca0 Fixed a typo.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1602 423420c4-83ab-492f-b58f-81f9feb106b5
2010-12-20 12:18:41 +00:00
Peter Åstrand
281d7c9f06 Changed license to GPLv3
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1534 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 08:31:06 +00:00
Jay Sorg
88855ddcbf update the copyright year
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1474 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 03:51:23 +00:00
Peter Åstrand
f6e5fe5f38 Indent fixes
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1428 423420c4-83ab-492f-b58f-81f9feb106b5
2008-01-24 08:06:02 +00:00
Matt Chapman
2e16fa661d Add some more warnings and sanity checks.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1425 423420c4-83ab-492f-b58f-81f9feb106b5
2008-01-05 05:43:02 +00:00
Pierre Ossman
421c2386d3 Improve readability of smart card code.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1414 423420c4-83ab-492f-b58f-81f9feb106b5
2007-07-03 14:08:06 +00:00
Peter Åstrand
75bd1939f8 Improve performance of (large) directory listings: Avoid
stat:ing each file many times.

The patch modifies rdesktop so that the g_notify_stamp is only set
when writing. Also, the stamp is not set before disk_create_notify(),
since this would mean that NotifyInfo would be called twice directly.

With this patch, the number of stat:s has dropped from 24 to 4, using
my tests.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1401 423420c4-83ab-492f-b58f-81f9feb106b5
2007-04-10 11:22:10 +00:00
Jay Sorg
6091381a81 prefix BOOL with RD_
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1371 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-08 04:47:06 +00:00
Jay Sorg
797df4fa02 copyright year update
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1364 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-04 05:39:39 +00:00
Jay Sorg
b670bdacfa RD_ prefix and win32 compatibility for core files
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1363 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-04 04:55:56 +00:00
Michael Gernoth
c3f49ea246 more smartcard locking fixes
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1327 423420c4-83ab-492f-b58f-81f9feb106b5
2006-11-03 23:51:35 +00:00
Michael Gernoth
8419d91138 make sure to lock the datapath of rdpdr_send_completion to prevent
simultaneous access to shared variables in multiple threads


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1326 423420c4-83ab-492f-b58f-81f9feb106b5
2006-11-03 19:56:42 +00:00
Michael Gernoth
24680f4f8d clean up smartcard debugging
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1318 423420c4-83ab-492f-b58f-81f9feb106b5
2006-11-02 20:48:28 +00:00
Michael Gernoth
f37c871e8b Smartcard support by Alexi Volkov <alexi@pravex.kiev.ua> and additional
patches for smartcard-support by Jennings Jared <jared.jennings.ctr@eglin.af.mil>


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1308 423420c4-83ab-492f-b58f-81f9feb106b5
2006-11-01 20:52:01 +00:00
Michael Gernoth
7ffe422a52 Slightly modified long filenames-patch from Alex Miller <asm at asm.kiev.ua>
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@977 423420c4-83ab-492f-b58f-81f9feb106b5
2005-08-15 11:44:35 +00:00
Peter Åstrand
a3360b8463 _rdpdr_check_fds should be static.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@947 423420c4-83ab-492f-b58f-81f9feb106b5
2005-08-02 09:45:11 +00:00
Peter Åstrand
f5bce2e0a9 Indent fixes
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@878 423420c4-83ab-492f-b58f-81f9feb106b5
2005-04-03 18:08:05 +00:00
Michael Gernoth
4cca15390d remove C++-style comments
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@864 423420c4-83ab-492f-b58f-81f9feb106b5
2005-03-15 11:25:50 +00:00
Michael Gernoth
ec643e4718 bump version to 1.4.0
change year in files
add missing docu for updated commandline-flags
update changelog


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@827 423420c4-83ab-492f-b58f-81f9feb106b5
2005-03-06 21:11:18 +00:00
Michael Gernoth
53eabea36f Big serial- and disk-redirection update from
Andreas Flick <Andreas.Flick@unicon-ka.de>


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@794 423420c4-83ab-492f-b58f-81f9feb106b5
2004-11-03 13:56:52 +00:00
Jay Sorg
c0651b51a1 change HANDLE to NTHANDLE to avoid conflics
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@775 423420c4-83ab-492f-b58f-81f9feb106b5
2004-10-02 01:30:33 +00:00
Michael Gernoth
65a649565d Applied serial-fixes from Huang Yushuo <huangys@xynetsoft.com>
Tested connection with ZOC and HyperTerm on Windows


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@754 423420c4-83ab-492f-b58f-81f9feb106b5
2004-08-24 21:37:25 +00:00