The logon packets wants a mandatory null termination
to be written to stream if not string is available.
The current design was to do if statements at those
points to handle this. Refactored that code into
function rdp_out_unistr_mandatory_null() for a
cleaner code when building up the packets.
Commit 78a4f41, forces the caller to handle the write of empty string byte
where protocol needs it. This commit fixes the RDP V4 logon packet which needs
a mandatory 2 bytes null terminator to be written if strings are empty.
Fixes issue #67
within rdp_connect() loop.
Fixes silent exits of rdesktop when receiving a redirection
PDU before license handling which is a corner case appeared
while using CredSSP+Kerberos.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1825 423420c4-83ab-492f-b58f-81f9feb106b5
This fix a bug where redirection using CredSSP fails to SSO
due to wrong password sent to server and asks for a correct one.
The source to this issue was that the password was zeroed before
the actual redirection is handled.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1795 423420c4-83ab-492f-b58f-81f9feb106b5
The process of packets in rdp_connect assumes that the
first packets are demand active to set g_rdp_shareid which
is not true. In case when CredSSP+Kerberos is in use an
enhanced redirection PDU packet is sent before the demande
active PDU.
This fixes the problem with rdesktop silently exists in
the case above.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1794 423420c4-83ab-492f-b58f-81f9feb106b5
This is needed on 2012r2 were server will not disconnect
a rdp connection after a redirect packet.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1777 423420c4-83ab-492f-b58f-81f9feb106b5
instead of using hardcoded buffer sizes and assumtion that conversion
just fits the size.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1773 423420c4-83ab-492f-b58f-81f9feb106b5
- Removed unused LOGON_BLOB code
- Removed AUTOLOGON, if password is null no logon will be
performed anyway.
- Comments of fields written to packet
- Clarified string handling difference between TS_INFO_PACKET
and TS_EXTENDED_INFO_PACKET
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1766 423420c4-83ab-492f-b58f-81f9feb106b5
and not a unicode string, which is passed though as a password
during the redirection.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1765 423420c4-83ab-492f-b58f-81f9feb106b5
However there is a change in the length compared to current
implementation which has provenly been working, so lets handle it
with a flag for now.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1764 423420c4-83ab-492f-b58f-81f9feb106b5
unclear specs. The data is processed in lower layers
in the protocol stack.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1763 423420c4-83ab-492f-b58f-81f9feb106b5
Renamed redirect cookie to proper redirect load balance info,
also made it dynamically allocated due to its variable length.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1756 423420c4-83ab-492f-b58f-81f9feb106b5
- Make sure that ui is created if processing demand active PDU
- Make sure we use precached bitmap cache again
This fixes bugs #367 and #368
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1732 423420c4-83ab-492f-b58f-81f9feb106b5
disabled by default and is enabled using argument --enable-credssp
to configure script.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1676 423420c4-83ab-492f-b58f-81f9feb106b5
rdssl_ to prevent nameclashing with openssl library now
when we link against ssl library.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1665 423420c4-83ab-492f-b58f-81f9feb106b5
adding Enhanced RDP Security support to rdesktop and brings
support for TLSv1 tunnel functionality.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1659 423420c4-83ab-492f-b58f-81f9feb106b5
call sizeof or strlen on a new dynamically allocated string.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1639 423420c4-83ab-492f-b58f-81f9feb106b5
size, and the screen size is changed, rdesktop will automatically
reconnect using the new screen size. This feature uses the previously
implemented autoreconnect feature.
The new UI function ui_seamless_end() has been introduced, to make it
possible to resize in seamless mode as well.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1556 423420c4-83ab-492f-b58f-81f9feb106b5
reconnect random. It seems to work anyway, but let's take care.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1541 423420c4-83ab-492f-b58f-81f9feb106b5
client can re-connect using a cookie, instead of going through the
normal authentication. This patch saves those cookies, and uses them
during logon.
Note that this feature is currently unused. It remains to add support
for, say, detecting when the TCP connection has gone done and restart
a new one.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1539 423420c4-83ab-492f-b58f-81f9feb106b5
disc variable is incorrect. Removed the variable, since it's always
False.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1508 423420c4-83ab-492f-b58f-81f9feb106b5
to a disconnected session (I do not know if this is a bug or a feature).
Previously we would drop the connection.
I suspect that in general we shouldn't be dropping the connection in
response to the disconnect PDU; we should treat it as informative like the
logon PDU and just save the status.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1237 423420c4-83ab-492f-b58f-81f9feb106b5
since that's what our local state variable is initialized to.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1216 423420c4-83ab-492f-b58f-81f9feb106b5
Many thanks to Vahur Sinijärv <vahur.sinijarv@cydonia.ee> for
finding the fix.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@885 423420c4-83ab-492f-b58f-81f9feb106b5
Currently disabled, need HAVE_ICONV and HAVE_ICONV_H defined to be
used. This should be done with a new configure test.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@854 423420c4-83ab-492f-b58f-81f9feb106b5
change year in files
add missing docu for updated commandline-flags
update changelog
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@827 423420c4-83ab-492f-b58f-81f9feb106b5
