Commit Graph

1536 Commits

Author SHA1 Message Date
Peter Åstrand
058ee33be3 Clean up and document the return values. Trying to solve a number of issues:
* The current return values have been selected pretty much without any
thought. Basically, the value 1 is used for all different kinds of
errors, except for a corner case where the server doesn't send a
RDP_PDU_DEACTIVATE in combination with a few special "reasons", where
the value 2 is used instead.

* rdesktop will currently also return with 2 if the user is closing
the rdesktop window, the same error as many other fatal errors, which
is somewhat strange.

* The main principle of my patch is to utilize more of the available
256 return codes. We are currently only using 3 values out of
256. This is bad; rdesktop should expose more information to the
caller about error conditions if it can.

Besides using the standardized exit codes for generic errors such as
EX_USAGE for command line usage errors, I've also exposed the
"extended disconnect reasons" from RDP. This allows for, for example,
to be able to distinguish between a logoff and a disconnect.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1510 423420c4-83ab-492f-b58f-81f9feb106b5
2009-09-02 13:03:43 +00:00
Peter Åstrand
5c67800d15 Indent fixes; ran indent-all with modern indent (F11)
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1509 423420c4-83ab-492f-b58f-81f9feb106b5
2009-08-27 08:35:48 +00:00
Peter Åstrand
ea46f1729d process_data_pdu never returns True nowadays, so the comment about the
disc variable is incorrect. Removed the variable, since it's always
False.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1508 423420c4-83ab-492f-b58f-81f9feb106b5
2009-08-27 07:30:32 +00:00
Peter Åstrand
55eaf2a098 Fix build with DEBUG: depth variable is no longer.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1507 423420c4-83ab-492f-b58f-81f9feb106b5
2009-08-26 15:20:32 +00:00
Peter Åstrand
be2812888f Applied patch by Enrico Scholz:
autoconf: renamed socklen_t_equiv to socklen_t_ac_equiv - ID: 2624071



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1506 423420c4-83ab-492f-b58f-81f9feb106b5
2009-08-26 12:34:04 +00:00
Peter Åstrand
e5e7b5572f Minor changes to make this README reStructured text.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1505 423420c4-83ab-492f-b58f-81f9feb106b5
2009-05-15 11:41:40 +00:00
Peter Åstrand
32e66f94b8 Removed empty script sections
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1485 423420c4-83ab-492f-b58f-81f9feb106b5
2008-12-12 13:49:01 +00:00
Peter Åstrand
c7feab2840 Ran indent-all
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1484 423420c4-83ab-492f-b58f-81f9feb106b5
2008-11-25 08:05:25 +00:00
Jay Sorg
a42c5895f6 added brushtest
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1483 423420c4-83ab-492f-b58f-81f9feb106b5
2008-11-02 03:55:00 +00:00
Jay Sorg
c3dc159869 brush cache for > 2 color brushes
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1482 423420c4-83ab-492f-b58f-81f9feb106b5
2008-11-01 02:37:10 +00:00
Peter Åstrand
b64678c9ee Temporarily disabled the recently added brush cache feature, due to
bug 2167833.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1481 423420c4-83ab-492f-b58f-81f9feb106b5
2008-10-20 07:16:43 +00:00
Peter Åstrand
d87e27483f Reworked device opening, only open the device with the access that we
currently needs. Avoids transmitting recording data on playback with padsp.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1480 423420c4-83ab-492f-b58f-81f9feb106b5
2008-10-02 18:21:58 +00:00
Peter Åstrand
edbae085f1 Everything except oss_register can be static
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1479 423420c4-83ab-492f-b58f-81f9feb106b5
2008-10-02 09:48:20 +00:00
Peter Åstrand
27388283ad Removed the hardcoded limit of the username length.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1478 423420c4-83ab-492f-b58f-81f9feb106b5
2008-09-26 11:40:54 +00:00
Peter Åstrand
bf4c26c110 Two minor fixes to avoid compiler warnings.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1477 423420c4-83ab-492f-b58f-81f9feb106b5
2008-09-26 11:32:43 +00:00
Jay Sorg
c9a4156554 update the copyright year
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1476 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 06:01:18 +00:00
Jay Sorg
f306257aa4 ran indent and removed some spaces at EOL
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1475 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 03:55:52 +00:00
Jay Sorg
88855ddcbf update the copyright year
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1474 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 03:51:23 +00:00
Jay Sorg
b59c4b92a6 added brush cache
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1473 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 03:35:24 +00:00
Matt Chapman
14ce531d73 Update ChangeLog
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1471 423420c4-83ab-492f-b58f-81f9feb106b5
2008-05-11 06:15:40 +00:00
Peter Åstrand
42abc7d5b2 Corrected last patch; rdpsnd_dsp_resample_set is not needed, since we perform the duplication ourselves.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1470 423420c4-83ab-492f-b58f-81f9feb106b5
2008-04-25 11:17:21 +00:00
Peter Åstrand
fced134989 Workaround to support recording on Sun Ray x86 systems.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1469 423420c4-83ab-492f-b58f-81f9feb106b5
2008-04-24 15:11:17 +00:00
Peter Åstrand
f6d95062f2 Indented
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1468 423420c4-83ab-492f-b58f-81f9feb106b5
2008-04-24 14:13:28 +00:00
Matt Chapman
71e90d1f56 Fix for Windows 2008 Server (see Patch #1744033)
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1467 423420c4-83ab-492f-b58f-81f9feb106b5
2008-04-05 07:37:02 +00:00
Matt Chapman
7902a19869 Update to tr keymap (Patches #1907097)
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1466 423420c4-83ab-492f-b58f-81f9feb106b5
2008-04-05 06:31:37 +00:00
Matt Chapman
5c7d320c99 Update to fr-ca keymap from ticpu@users.sourceforge.net (Bug #1904884)
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1465 423420c4-83ab-492f-b58f-81f9feb106b5
2008-04-05 06:24:26 +00:00
Matt Chapman
b25d176fe1 Bump version number in preparation for release.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1464 423420c4-83ab-492f-b58f-81f9feb106b5
2008-04-05 06:15:45 +00:00
Matt Chapman
231c3f1285 Fix bug #1886199 (tracked down by nicolyon@users.sourceforge.net).
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1463 423420c4-83ab-492f-b58f-81f9feb106b5
2008-04-05 05:56:26 +00:00
Peter Åstrand
a37022eba5 Moved call to seamless_restack_test from ui_init to end of
ui_create_window. This seems to fix problems the WTS disconnecting the
session due to "DATA ENCRYPTION" errors. At this point, it's unknown
why this patch fixes the problem, but ui_create_window is a good place
for seamless_restack_test() in any case.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1462 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-28 11:36:15 +00:00
Peter Åstrand
079a5c0048 Numbered test cases
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1461 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-27 16:15:21 +00:00
Peter Åstrand
af3925665a Decreased timeout in sw_wait_configurenotify to one second, to reduce
frusrtation with old metacity versions. Need to use gettimeofday.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1460 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-26 17:16:32 +00:00
Peter Åstrand
3a949d3127 Re-worked the support for SeamlessRDP window stacking:
* Since many window managers cannot properly restack a window between
two other windows, we need to check for this at startup.

* A new utility function, sw_wait_configurenotify, is used to wait for
the WM to process our restacking request.

* We are using XReconfigureWMWindow instead of XRestackWindows and
XRaiseWindow, to easier meet the demands of ICCCM. Restacking between
is only done if the WM is not broken, though.

* The error handler does not ignore BadMatch from ConfigureWindow
requests any longer. I haven't found any WM that gives BadMatch for
XReconfigureWMWindow.

* The test cases has been updated to test more stacking cases.


A somewhat related bug fix wrt focus handling is also included, which
prevents FOCUS messages when reverting focus from a destroyed window


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1458 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-26 16:44:55 +00:00
Peter Åstrand
d7f206df6c Added TODO about reconnecting and icons
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1457 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-25 15:13:47 +00:00
Peter Åstrand
9a4bfd1c8d Testing without WM is also a good idea. Added two new test cases.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1456 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-24 17:54:33 +00:00
Peter Åstrand
4f21fb4975 Added simple tool for SeamlessRDP testing
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1455 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-24 17:49:06 +00:00
Peter Åstrand
f1bcaa9f3e Reminder: test different WMs
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1453 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-14 07:43:46 +00:00
Peter Åstrand
d654753ea6 SeamlessRDP bugfix: The first window to XRestackWindows should be the
reference window (the "behind" window); not the window to restack.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1452 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-14 07:39:38 +00:00
Peter Åstrand
bf69855fea New test case for window restacking, using Seamonkey.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1451 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-14 07:36:26 +00:00
Peter Åstrand
67ef23c78f Clarified the ZCHANGE message.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1450 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-14 07:34:56 +00:00
Peter Åstrand
ed95a017b1 Verify About and Open dialog focus as well.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1447 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-11 08:10:58 +00:00
Peter Åstrand
8524a3fcf2 Applied patch:
[ 1715358 ] seamlessrdp window close


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1446 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-07 11:27:12 +00:00
Peter Åstrand
d7760c34fe Added test case for local window close.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1445 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-07 09:04:04 +00:00
Peter Åstrand
0538dcc549 Icons are supported, but there's still a problem with topmost windows
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1444 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-06 15:49:29 +00:00
Peter Åstrand
6718610779 Applied rdesktop part of patch:
[ 1715359 ] seamlessrdp topmost windows


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1442 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-06 15:39:21 +00:00
Peter Åstrand
09e3df9353 Let's allow C99 in SeamlessRDP. The current code is not compatible with C89 anyway.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1440 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-06 15:28:32 +00:00
Peter Åstrand
301677f200 Two more test cases.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1437 423420c4-83ab-492f-b58f-81f9feb106b5
2008-03-06 13:10:53 +00:00
Peter Åstrand
e31a40617d Added test cases
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1435 423420c4-83ab-492f-b58f-81f9feb106b5
2008-02-20 17:18:30 +00:00
Matt Chapman
3808350adb Fix from Paul Whitaker: It is not safe to assume that free space
available at the top of the tree is indicative of free space anywhere in
the tree, because you may wish to redirect a mount point hierarchy.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1434 423420c4-83ab-492f-b58f-81f9feb106b5
2008-02-16 00:15:43 +00:00
Matt Chapman
33669ac780 Extra sanity checking.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1433 423420c4-83ab-492f-b58f-81f9feb106b5
2008-02-14 11:45:13 +00:00
Pierre Ossman
3c70034691 Properly store the current device settings for full duplex operation.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1432 423420c4-83ab-492f-b58f-81f9feb106b5
2008-02-08 10:40:56 +00:00