Commit Graph

2003 Commits

Author SHA1 Message Date
Karl Mikaelsson
a27c0ac4c8 Silence "sec_process_crypt_info(), failed to parse crypt info" msgs
If sec_parse_crypt_info returns false, it's not always a problem with
parsing the crypt info. It could very well be that Enhanced RDP
Security is used, which would trigger a false return value from the
function.

This commit adds new log messages to sec_parse_crypt_info for cases it
would return false and removes the incorrect catch-all message from
the caller.
2017-09-20 16:18:13 +02:00
Henrik Andersson
1aaafc80c0 Always prompt for password if not provided via commandline.
This fixes several issues where credentials are required
before the connection is carried out. Such as dual
authentication prompts when redirected by load balancer.
2017-08-15 12:37:14 +02:00
Henrik Andersson
b25f93c0e6 Run indentation script 2017-08-15 10:50:08 +02:00
Henrik Andersson
c07bfffabf Use a prompt reflecting password or smart card pin 2017-08-15 10:48:35 +02:00
Henrik Andersson
8586cfc8cb Remove deprecated rdp2vnc
Fixes issue #95
2017-08-14 15:58:48 +02:00
Henrik Andersson
5c5637f900 Remove use of deprecated gssglue
gssglue wrapper was removed in PR #131
2017-08-14 12:26:26 +02:00
Henrik Andersson
70faf7c7bd Merge pull request #131 from CendioOssman/gss
Use standard GSSAPI rather than libgssglue
2017-08-14 12:24:46 +02:00
Henrik Andersson
b316e9721a Merge pull request #139 from uglym8/full_ci_build
CI build with smartcard and CredSSP support
2017-08-14 12:12:26 +02:00
Alexander Zakharov
90c0a3c6dd CI build with smartcard and CredSSP support 2017-08-09 23:26:43 +03:00
Pierre Ossman
b556651fe1 Use standard GSSAPI rather than libgssglue
That project is abandoned and the distributions aren't including
it anymore.
2017-07-10 15:14:01 +02:00
Pierre Ossman
71f1cfb909 Fix pointer types for gss_wrap()/gss_unrap()
We were using the incorrect type for the context for these two calls.
No practical effects, but some noise from the compiler about the wrong
pointer type.
2017-07-10 15:12:26 +02:00
Pierre Ossman
b236a3698f Merge branches 'shift_pause' and 'mouse_4_5' of https://github.com/bogbert/rdesktop 2017-07-10 15:00:47 +02:00
Pierre G. Bogossian
ba94ac028d Shift-Pause did not work because a PAUSE key press was not sending the proper sequence 2017-07-09 16:58:19 +02:00
Pierre G. Bogossian
9889ed6457 Support extended mouse buttons 4 and 5 (ie back/forward buttons) 2017-07-09 16:56:30 +02:00
Henrik Andersson
f616b2c1f9 Release scard context if not used 2017-07-07 13:12:38 +02:00
Henrik Andersson
82d99335a3 Add docs for clipboard redirection 2017-07-07 09:53:45 +02:00
Henrik Andersson
bba4cd2cf0 Merge pull request #125 from uglym8/fix_118
Workaround for key caching in OpenSSL > 1.1.0 ( fixes #118)
2017-07-05 14:15:01 +02:00
Alexander Zakharov
a3dfceefc2 Workaround for key caching in OpenSSL > 1.1.0
Since v.1.1.0 the key caching has been added to OpenSSL.
After X.509 had been parsed there is no point in changing of key
algorithm as the key had already been decoded and cached result will
be returned anyway. (check crypto/x509/x_pubkey.c: X509_PUBKEY_get0())
2017-06-21 15:38:58 +03:00
Henrik Andersson
ba804fa723 Include keymaps based on a wider wildcard
Fixes issue #123 where fr-bepo was not included in the
tarball nor installed by installkeymaps target.
2017-06-12 14:15:59 +02:00
Henrik Andersson
b872ddb21d Ran indent script 2017-06-07 09:39:29 +02:00
Henrik Andersson
2615f08203 Add keymap mask to handle en-us-intl
This kyemap was never included into the source tarball nor installation
due to the missing file mask match. With this commit it is included as
expected.

Fixes issue #112
2017-06-07 08:10:33 +02:00
Henrik Andersson
931fdd2398 Package of README.md file 2017-06-07 08:05:47 +02:00
Henrik Andersson
05689dbc99 Fix to reset clipping at reconnect resize
The previous fix for clipping problems was not enough, reverted
that change in xwin.c in favor for adding reset of window clipping
rect at reconnect.

Fix issue #117
2017-05-15 14:57:50 +02:00
Henrik Andersson
b9481bb01b Fix reconnection using the cookie
The use of redirection cookie was never done due to global
g_redirect flag was cleared on the wrong place. This fixes
the problem with dual authentication prompts when redirect
to another server upon connect.

Fixes issue #18
2017-05-15 08:36:41 +02:00
Henrik Andersson
708b0f0071 Rename redirection flags matching names in specification
Also added missing flags available from spec
2017-05-15 08:03:39 +02:00
Henrik Andersson
5b7b955487 Fix typo in log 2017-05-15 06:13:13 +02:00
Henrik Andersson
908ad64d84 Add additional logging for SSL errors
This was added to provide more information when things fails
as in  issue #118.
2017-05-12 13:15:45 +02:00
Henrik Andersson
7d8675074f Fail SCardEstablishContext if no readers connected
Windows smartcard application generally behaves better with polling of smartcard
subsystem availability than when there are no smartcard readers available.

This is a potential workaround for issue #109
2017-03-29 13:45:04 +02:00
Henrik Andersson
b37cbe9abd Refactor for cleaner code flow 2017-03-29 13:36:43 +02:00
Henrik Andersson
b01625b284 Merge pull request #106 from Nassim26/patch-1
Fixed grammar mistakes
2017-03-09 12:29:41 +01:00
Henrik Andersson
2c9a706c23 Fix X error BadAlloc when using seamlessrdp
The introduction of setting session size using percentages of both
with and height of screen like -g 50%x100%, commit 3140824be
introduced a bug when using seamless rdp. This commit fixes this bug.
2017-03-09 12:25:10 +01:00
Henrik Andersson
c93960b266 Cleanup of TS_SECURITY_HEADER code
Add correct naming of header TS_SECURITY_HEADER and its flags
as per MSRDPBCGR specification.
2017-03-07 15:32:14 +01:00
Nassim Beladel
a35e9bc52a Fixed some grammar mistakes 2017-03-06 20:01:20 +01:00
Nassim Beladel
9f3c978ab1 Fixed a small typo 2017-03-06 17:36:43 +01:00
Nassim Beladel
7e46a9db39 Fixed some typo's 2017-03-06 17:34:16 +01:00
Henrik Andersson
1e68d67298 Run indent-all script 2017-03-03 09:31:26 +01:00
Henrik Andersson
af36ac3a64 Add log of reason for protocol negotiation failure
Fixes issue #104
2017-03-03 09:29:53 +01:00
Henrik Andersson
0b745346e2 Update README.md 2017-02-27 11:04:29 +01:00
Henrik Andersson
f4a19e73ad Update README.md 2017-02-27 11:03:49 +01:00
Henrik Andersson
04219c2b6c Rename README,md to README.md 2017-02-27 11:02:04 +01:00
Henrik Andersson
8adc0f9a21 Update and rename README to README,md
Change the current README file into a markdown formatted README
2017-02-27 11:01:40 +01:00
Henrik Andersson
d124477abb Merge pull request #96 from derfian/decipher-rdpdr-printer-device-announce
Clarify printer parts of rdpdr_send_client_device_list_announce
2017-01-30 10:05:02 +01:00
Henrik Andersson
3acc444c75 Merge pull request #93 from hean01-cendio/logging
Rework the logging system
2017-01-30 09:36:02 +01:00
Karl Mikaelsson
7f6748d1c3 Clarify printer parts of rdpdr_send_client_device_list_announce
Add new flag constants and comments for all fields.
2017-01-30 09:35:29 +01:00
Henrik Andersson
7b9a09e173 Merge branch 'master' into logging 2017-01-27 10:56:16 +01:00
Henrik Andersson
2517b15bb4 Merge pull request #94 from derfian/long-drive-share-name
Send longer drive names for redirected drives
2017-01-27 10:54:13 +01:00
Henrik Andersson
87d8d123b8 Rework the logging system
This commit will add a logging system to solve the problem that
one actually need to recompile rdesktop from source to enable
different debug logging.

- Same logging api  for all kind of logging and messages to
   end user.

- Adding -v for verbose output when running rdesktop.

- All messages are logged into a subject and with a type, eg:

     logger(Keyboard, Notice, "Autos-electing %s based on locale.", locale);

- Debug logging is enabled trough a environment variable RDEKSTOP_DEBUG,
  which specifies subjects of interest, comma separated. There is a special
  subject named All which includes all subject for debug loggin. There is also
  a simple logic opeartor '!' = NOT which can be used in combination like:

    RDESKTOP_DEBUG=All,!Graphics,!Sound

  Which would give debug log output for All subject except Graphics and Sound.
2017-01-26 14:19:40 +01:00
Karl Mikaelsson
90ea473750 Send longer drive names for redirected drives
Store the full drive name in a new disk-specific pdevice_data
struct. Bump Drive Redirection version to 02, and send the full name
as part of the Device Announcement message.
2017-01-25 13:27:01 +01:00
Henrik Andersson
71bf45a5d7 Ran indent-all script 2017-01-25 00:34:37 +01:00
Henrik Andersson
14a4bf2d1d Use the correct mask for XSendEvent()
Sending ClientMessage is plain wrong.
2017-01-24 23:45:17 +01:00