Commit Graph

1881 Commits

Author SHA1 Message Date
Henrik Andersson
d3c4cb3535 Run indentation script.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1805 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-20 14:34:45 +00:00
Henrik Andersson
35ed85c03b Reducing hash and keymap hashtable slots from 65535
to 127 which will reduce memory footprint.

Tested using a few keymaps and With 0x7f there were
max 5 collisions in a slot which is good for
performance. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1804 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-20 11:24:59 +00:00
Henrik Andersson
2a76ef7b53 Handle trailing whitespace in a keyname sequence.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1803 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-20 10:52:39 +00:00
Henrik Andersson
cb06fe1863 Applied slightly modified patch #220 that fixes
hash collisions with keysyms.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1802 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-20 10:43:03 +00:00
Henrik Andersson
e597ef4e90 Make sure to use rdp_out_unistr() when writing strings
to streams in CredSSP. (The other part of bug #383.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1801 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-20 07:49:52 +00:00
Henrik Andersson
77ec7d1128 Use rdp_out_unistr to fill in string in tspasswordcreds
packet. This fixes bug were login fails due to non-ASCII
characters in username or password.

Fixes bug #383.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1800 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-20 07:40:17 +00:00
Henrik Andersson
a563c49723 Use correct types for reading cursot hotspot and
clamp the point into cursor boundingbox.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1799 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-20 06:27:09 +00:00
Henrik Andersson
f000599925 Fix typo.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1798 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-13 14:36:18 +00:00
Henrik Andersson
4a4d0a9160 Updated comment to be more clarifying.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1797 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-13 14:34:23 +00:00
Henrik Andersson
8c7c645285 Reintroduce special caps flag 0x00800000 which got
removed in commit r1791.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1796 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-13 14:03:08 +00:00
Henrik Andersson
a1f8856484 Make password variable global and clear it in correct place.
This fix a bug where redirection using CredSSP fails to SSO
due to wrong password sent to server and asks for a correct one.
The source to this issue was that the password was zeroed before
the actual redirection is handled.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1795 423420c4-83ab-492f-b58f-81f9feb106b5
2014-04-24 12:02:40 +00:00
Henrik Andersson
708c3861f1 Remove process of packets in rdp_connect.
The process of packets in rdp_connect assumes that the
first packets are demand active to set g_rdp_shareid which
is not true. In case when CredSSP+Kerberos is in use an
enhanced redirection PDU packet is sent before the demande
active PDU.

This fixes the problem with rdesktop silently exists in
the case above.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1794 423420c4-83ab-492f-b58f-81f9feb106b5
2014-04-23 06:11:55 +00:00
Peter Åstrand
a8e9328c9f 0x35 in dutch layout should be for minus; not hyphen
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1793 423420c4-83ab-492f-b58f-81f9feb106b5
2014-04-15 11:28:00 +00:00
Henrik Andersson
f545366312 Add no_cursor_shadow to default performance flags.
This fix the cursor issues on Window 2012



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1792 423420c4-83ab-492f-b58f-81f9feb106b5
2014-03-12 06:22:28 +00:00
Henrik Andersson
b8557c42ea Always enable rdpsnd channel and use flags to control use
of streamed audio or not.

This is a fix for driveredirection which requires rdpsnd
channel to work as mentioned in the following post.

http://social.msdn.microsoft.com/Forums/en-US/75024a3d-458f-4ed9-b55d-7852d0113bd7/rdpbcgrpdf-2-minors-problems-with-server-2012
 


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1791 423420c4-83ab-492f-b58f-81f9feb106b5
2014-03-06 11:43:43 +00:00
Henrik Andersson
e21475f3dc Change default printer driver to "MS Publisher Imagesetter".
Fixes bug #348



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1790 423420c4-83ab-492f-b58f-81f9feb106b5
2014-03-06 08:32:02 +00:00
Henrik Andersson
38ca609c78 Added minimal implementation for TS_AUTORECONNECT_STATUS_PDU.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1789 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-19 08:57:51 +00:00
Henrik Andersson
6e5bb07c9c Clear memory before use. Fixes bug where hash of licensefilename
differs between load and save.

Thanks to Florent Peterschmitt for reporting,testing and patch.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1788 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-19 08:02:07 +00:00
Henrik Andersson
6364680a8c Don't send incomplete connection request packet on reconnect.
Fixes connection error when reconnecting after a network error
or pending_resize disconnection..



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1787 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-07 14:08:00 +00:00
Henrik Andersson
f28bddc81b Fix bug with broken auto reconnect packet, introduced
in commit 1766.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1786 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-07 13:10:45 +00:00
Henrik Andersson
dbb87244dd Reset license issued state to make redirections work with issued device licenses.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1785 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-07 08:44:55 +00:00
Henrik Andersson
f9cb55471d Initialize g_hostname at declaration.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1784 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-07 07:33:04 +00:00
Henrik Andersson
0628179dba Send correct type for new licence request.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1783 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-06 10:33:44 +00:00
Henrik Andersson
f8b0b64742 Update licence constants to match specs for clarity
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1782 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-06 10:32:52 +00:00
Henrik Andersson
b9d0c366e2 Update debug log to use the new license constants.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1781 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-06 09:48:56 +00:00
Henrik Andersson
f613559ea5 Added a handler for license error alert.
There is a special case in here we need to consider, when no license is received
from the server we will get a License Error Alert PDU - Valid Client packet which
indicates that everything is ok.

This solves a connection error which resulted in protocol error 76.




git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1780 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-05 11:58:22 +00:00
Henrik Andersson
b4dfb9b5e0 Use license terms used in specification for easier overview.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1779 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-05 09:50:29 +00:00
Henrik Andersson
7ece007132 Fix indentation...
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1778 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-12 14:01:58 +00:00
Henrik Andersson
c618390bbe Break out of rdp main loop if server sent a redirect PDU.
This is needed on 2012r2 were server will not disconnect
a rdp connection after a redirect packet.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1777 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-10 11:16:56 +00:00
Henrik Andersson
f5eac11fe8 Do not rename printercache blob if we dont have
source and dest name.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1776 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-06 13:56:37 +00:00
Henrik Andersson
013ac6d541 Make sure to check agains null pointer in disk_create()
Simplified FileRenameInformation in disk_set_information()
and handle error if newname is null.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1775 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-06 13:52:29 +00:00
Henrik Andersson
fe10877ed5 Make sure we free memory allocated by rdp_in_unistr()
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1774 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-06 13:36:00 +00:00
Henrik Andersson
f0b6604347 Changed rdp_in_unistr() to make dynamic allocation of converted string
instead of using hardcoded buffer sizes and assumtion that conversion
just fits the size.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1773 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-06 12:43:08 +00:00
Henrik Andersson
6de37a4f3b Dynamic allocation of redirect username.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1772 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-06 07:54:51 +00:00
Henrik Andersson
8c5d480bf3 Use g_redirect flag when creating a logon packet and clear
the flag when finished.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1771 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-04 11:52:33 +00:00
Henrik Andersson
48f661b1b0 Fix issue with WTS 2003 and a case were a network error
is triggered at a server redirect, preventing connection
to the new server.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1770 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-04 11:45:37 +00:00
Henrik Andersson
723b636153 Redirect should not take the codepath as a reconnect
which uses its own cookie and another code path.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1769 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 15:13:56 +00:00
Henrik Andersson
a090d06331 Use redirect cookie instead of password if available.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1768 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 15:13:04 +00:00
Henrik Andersson
a2492ab3b0 Missed to run indent-all script of previous script.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1767 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 14:47:29 +00:00
Henrik Andersson
030333d7e1 Cleanup and clarify of TS_INFO_PAKCKET.
- Removed unused LOGON_BLOB code
- Removed AUTOLOGON, if password is null no logon will be
  performed anyway.
- Comments of fields written to packet
- Clarified string handling difference between TS_INFO_PACKET
  and TS_EXTENDED_INFO_PACKET



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1766 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 14:46:14 +00:00
Henrik Andersson
820a2f7bb8 Server redirect password should be interpreted as a binary blob
and not a unicode string, which is passed though as a password
during the redirection.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1765 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 11:59:05 +00:00
Henrik Andersson
a1db8d906c Fix issue while parsing the redirect packet to match the spec.
However there is a change in the length compared to current
implementation which has provenly been working, so lets handle it
with a flag for now.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1764 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 11:33:50 +00:00
Henrik Andersson
092f895a20 Revert an issue introduced by commit r1757 due to
unclear specs. The data is processed in lower layers
in the protocol stack.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1763 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 11:18:11 +00:00
Henrik Andersson
2503dbb9d9 Cleanup and clarify the implementation of TS_UD_CS_CLUSTER.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1762 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 11:10:35 +00:00
Henrik Andersson
448a16511f Fixe bug with size of destination for unistr convert.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1761 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-26 11:47:16 +00:00
Henrik Andersson
e63a44acb1 Completes previous commit r1759, making redirect server string
dynamically allocated when used.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1760 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-26 11:40:45 +00:00
Henrik Andersson
a080b6750e Make use of announce target FQDN in a redirect.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1759 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-26 11:26:49 +00:00
Henrik Andersson
3c110e5e17 Do not perform an actual redirect if server redirect pdu is
flagged as informational.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1758 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-26 11:06:32 +00:00
Henrik Andersson
f74729b592 Added handling of enhanced security redirect PDU.
Part of the rework of server redirection.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1757 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-26 08:21:06 +00:00
Henrik Andersson
3e0d255bfb Initial cleanup of the redirection implementation.
Renamed redirect cookie to proper redirect load balance info,
also made it dynamically allocated due to its variable length.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1756 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-26 07:56:04 +00:00