The old code was filled by assumtions that all symbols in utf16
is represented by 2 bytes which is not true and resulted in
truncated strings.
Fixes issue #60
This commit will add a logging system to solve the problem that
one actually need to recompile rdesktop from source to enable
different debug logging.
- Same logging api for all kind of logging and messages to
end user.
- Adding -v for verbose output when running rdesktop.
- All messages are logged into a subject and with a type, eg:
logger(Keyboard, Notice, "Autos-electing %s based on locale.", locale);
- Debug logging is enabled trough a environment variable RDEKSTOP_DEBUG,
which specifies subjects of interest, comma separated. There is a special
subject named All which includes all subject for debug loggin. There is also
a simple logic opeartor '!' = NOT which can be used in combination like:
RDESKTOP_DEBUG=All,!Graphics,!Sound
Which would give debug log output for All subject except Graphics and Sound.
Store the full drive name in a new disk-specific pdevice_data
struct. Bump Drive Redirection version to 02, and send the full name
as part of the Device Announcement message.
Simplified FileRenameInformation in disk_set_information()
and handle error if newname is null.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1775 423420c4-83ab-492f-b58f-81f9feb106b5
instead of using hardcoded buffer sizes and assumtion that conversion
just fits the size.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1773 423420c4-83ab-492f-b58f-81f9feb106b5
compiler errors if its used. Patch from Samuel.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1667 423420c4-83ab-492f-b58f-81f9feb106b5
bug 676252. Credits to Noam Rathaus <noamr@beyondsecurity.com> for
finding this bug.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1626 423420c4-83ab-492f-b58f-81f9feb106b5
disk_query_directory() implementation to support
vailable info classes.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1609 423420c4-83ab-492f-b58f-81f9feb106b5
recursive deletion of directory. This fixes bug 2906541 and
patch originates from 2909831.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1606 423420c4-83ab-492f-b58f-81f9feb106b5
the FileFsFullSizeInformation which solves the read-only issues
with disk redirections on Windows 7 and Windows 2008R2.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1605 423420c4-83ab-492f-b58f-81f9feb106b5
* The current return values have been selected pretty much without any
thought. Basically, the value 1 is used for all different kinds of
errors, except for a corner case where the server doesn't send a
RDP_PDU_DEACTIVATE in combination with a few special "reasons", where
the value 2 is used instead.
* rdesktop will currently also return with 2 if the user is closing
the rdesktop window, the same error as many other fatal errors, which
is somewhat strange.
* The main principle of my patch is to utilize more of the available
256 return codes. We are currently only using 3 values out of
256. This is bad; rdesktop should expose more information to the
caller about error conditions if it can.
Besides using the standardized exit codes for generic errors such as
EX_USAGE for command line usage errors, I've also exposed the
"extended disconnect reasons" from RDP. This allows for, for example,
to be able to distinguish between a logoff and a disconnect.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1510 423420c4-83ab-492f-b58f-81f9feb106b5
available at the top of the tree is indicative of free space anywhere in
the tree, because you may wish to redirect a mount point hierarchy.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1434 423420c4-83ab-492f-b58f-81f9feb106b5
stat:ing each file many times.
The patch modifies rdesktop so that the g_notify_stamp is only set
when writing. Also, the stamp is not set before disk_create_notify(),
since this would mean that NotifyInfo would be called twice directly.
With this patch, the number of stat:s has dropped from 24 to 4, using
my tests.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1401 423420c4-83ab-492f-b58f-81f9feb106b5
avoid confusion. (The variable name fstat also collides with the
function with the same name.)
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1400 423420c4-83ab-492f-b58f-81f9feb106b5
and I can't see any field allowing for longer names. This is not very
surprising, since native clients export drive names ("A", "H" etc.).
Telling the user that the name is truncated at seven, not eight,
characters.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@817 423420c4-83ab-492f-b58f-81f9feb106b5