Commit Graph

235 Commits

Author SHA1 Message Date
Henrik Andersson
07008abc10 Make sure to always add RDP5_NO_CURSOR_SHADOW even
when specifying that nothing should be disabled in
performance flags.

This is a workaround for rdesktop not supporting
alpha cursors.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1818 423420c4-83ab-492f-b58f-81f9feb106b5
2014-07-01 06:17:02 +00:00
Henrik Andersson
a87ed59ad4 Updates all constants for TS_INFO_PACKET flags to
much names in specification.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1817 423420c4-83ab-492f-b58f-81f9feb106b5
2014-06-27 13:49:19 +00:00
Henrik Andersson
1c97aa5be1 Fix constant naming and enabled windowskey by default.
Fixes bug #384

Thanks to Alexander Zakharov for pinpointing
the core issue.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1816 423420c4-83ab-492f-b58f-81f9feb106b5
2014-06-27 13:15:24 +00:00
Henrik Andersson
a1f8856484 Make password variable global and clear it in correct place.
This fix a bug where redirection using CredSSP fails to SSO
due to wrong password sent to server and asks for a correct one.
The source to this issue was that the password was zeroed before
the actual redirection is handled.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1795 423420c4-83ab-492f-b58f-81f9feb106b5
2014-04-24 12:02:40 +00:00
Henrik Andersson
f545366312 Add no_cursor_shadow to default performance flags.
This fix the cursor issues on Window 2012



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1792 423420c4-83ab-492f-b58f-81f9feb106b5
2014-03-12 06:22:28 +00:00
Henrik Andersson
b8557c42ea Always enable rdpsnd channel and use flags to control use
of streamed audio or not.

This is a fix for driveredirection which requires rdpsnd
channel to work as mentioned in the following post.

http://social.msdn.microsoft.com/Forums/en-US/75024a3d-458f-4ed9-b55d-7852d0113bd7/rdpbcgrpdf-2-minors-problems-with-server-2012
 


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1791 423420c4-83ab-492f-b58f-81f9feb106b5
2014-03-06 11:43:43 +00:00
Henrik Andersson
6e5bb07c9c Clear memory before use. Fixes bug where hash of licensefilename
differs between load and save.

Thanks to Florent Peterschmitt for reporting,testing and patch.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1788 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-19 08:02:07 +00:00
Henrik Andersson
f9cb55471d Initialize g_hostname at declaration.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1784 423420c4-83ab-492f-b58f-81f9feb106b5
2014-02-07 07:33:04 +00:00
Henrik Andersson
7ece007132 Fix indentation...
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1778 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-12 14:01:58 +00:00
Henrik Andersson
f0b6604347 Changed rdp_in_unistr() to make dynamic allocation of converted string
instead of using hardcoded buffer sizes and assumtion that conversion
just fits the size.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1773 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-06 12:43:08 +00:00
Henrik Andersson
6de37a4f3b Dynamic allocation of redirect username.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1772 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-06 07:54:51 +00:00
Henrik Andersson
48f661b1b0 Fix issue with WTS 2003 and a case were a network error
is triggered at a server redirect, preventing connection
to the new server.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1770 423420c4-83ab-492f-b58f-81f9feb106b5
2013-12-04 11:45:37 +00:00
Henrik Andersson
723b636153 Redirect should not take the codepath as a reconnect
which uses its own cookie and another code path.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1769 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 15:13:56 +00:00
Henrik Andersson
030333d7e1 Cleanup and clarify of TS_INFO_PAKCKET.
- Removed unused LOGON_BLOB code
- Removed AUTOLOGON, if password is null no logon will be
  performed anyway.
- Comments of fields written to packet
- Clarified string handling difference between TS_INFO_PACKET
  and TS_EXTENDED_INFO_PACKET



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1766 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 14:46:14 +00:00
Henrik Andersson
820a2f7bb8 Server redirect password should be interpreted as a binary blob
and not a unicode string, which is passed though as a password
during the redirection.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1765 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 11:59:05 +00:00
Henrik Andersson
2503dbb9d9 Cleanup and clarify the implementation of TS_UD_CS_CLUSTER.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1762 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-28 11:10:35 +00:00
Henrik Andersson
e63a44acb1 Completes previous commit r1759, making redirect server string
dynamically allocated when used.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1760 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-26 11:40:45 +00:00
Henrik Andersson
a080b6750e Make use of announce target FQDN in a redirect.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1759 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-26 11:26:49 +00:00
Henrik Andersson
3e0d255bfb Initial cleanup of the redirection implementation.
Renamed redirect cookie to proper redirect load balance info,
also made it dynamically allocated due to its variable length.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1756 423420c4-83ab-492f-b58f-81f9feb106b5
2013-11-26 07:56:04 +00:00
Henrik Andersson
697c0f190d Initialize deactivate variable and make sure we check it to
control reconnection logic.

When hitting cancel at the logon dialog, server will send a
deactivate PDU and close the socket the hard way. This behaviour
introduce a problem when using SSL connection were rdesktop
detected a network error and entered reconnection loop.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1748 423420c4-83ab-492f-b58f-81f9feb106b5
2013-09-27 08:18:34 +00:00
Henrik Andersson
d74b2d4278 Added 4 new disconnect reasons with corresponding return code.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1742 423420c4-83ab-492f-b58f-81f9feb106b5
2013-09-17 14:48:56 +00:00
Peter Åstrand
4bc4e5b473 Correct build warning caused by commit 1732.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1741 423420c4-83ab-492f-b58f-81f9feb106b5
2013-09-17 13:32:16 +00:00
Peter Åstrand
a049f3cc81 Removed unused variable.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1740 423420c4-83ab-492f-b58f-81f9feb106b5
2013-09-17 13:27:31 +00:00
Henrik Andersson
58363c5351 - Added rd_create_ui() helper function
- Make sure that ui is created if processing demand active PDU
- Make sure we use precached bitmap cache again

This fixes bugs #367 and #368



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1732 423420c4-83ab-492f-b58f-81f9feb106b5
2013-08-14 13:49:45 +00:00
Henrik Andersson
e0cfeaa585 Bitmap cache precaching is broken, tries to create bitmaps without window
which results in a sigsegv.

Workaround for bug #367



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1731 423420c4-83ab-492f-b58f-81f9feb106b5
2013-08-14 13:23:01 +00:00
Henrik Andersson
adbb6cf0fc Run indent-all script.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1721 423420c4-83ab-492f-b58f-81f9feb106b5
2013-06-20 12:57:00 +00:00
Henrik Andersson
e6b10f6bcb Added tcp_ui_run() to prevent ui_select() push data on transport
which corrupts the stream and prevents a SSL reconnect to work.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1720 423420c4-83ab-492f-b58f-81f9feb106b5
2013-06-20 12:51:27 +00:00
Henrik Andersson
cca2aefefe Make sure to reset encryption to initial value.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1715 423420c4-83ab-492f-b58f-81f9feb106b5
2013-06-20 04:01:10 +00:00
Henrik Andersson
cd7a7342cb Silence some error spamming when rdesktop is in reconnect loop.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1713 423420c4-83ab-492f-b58f-81f9feb106b5
2013-06-14 12:54:38 +00:00
Henrik Andersson
2374054495 Do not report each reconnection retry every 4 seconds, just log
that we entered reconnction loop and log errors.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1712 423420c4-83ab-492f-b58f-81f9feb106b5
2013-06-13 12:32:29 +00:00
Henrik Andersson
dfb3f21069 Fix indentation.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1708 423420c4-83ab-492f-b58f-81f9feb106b5
2013-04-12 08:06:01 +00:00
Henrik Andersson
eced6ca821 Reconnect upon network failure, retry as long the autoreconnect
cookie is valid.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1707 423420c4-83ab-492f-b58f-81f9feb106b5
2013-04-12 06:46:07 +00:00
Henrik Andersson
da3dcb8fbe Remove the use of getopt_long() introduced in previous commit.
Replace it with normal getopt() as we had before to prevent breaking
build of rdesktop on other platforms like solaris.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1706 423420c4-83ab-492f-b58f-81f9feb106b5
2013-03-25 15:56:32 +00:00
Henrik Andersson
d1e8fdc90a Initial support for CredSSP smartcard authentication.
- Add implementation of TSSmartCardCreds and TSCSPDataDetail for
  CredSSP protocol.
- Add handling of long opts for getopt()
- Added 4 new long opts for providing information to CredSSP which
  is required for smartcard credentials.
- Updated manual with information about the new arguments.

If smartcard authentication is request by commandline "-i" option,
and no CredSSP smartcard options is provided, rdesktop will
negotiate to use SSL and warn.




git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1705 423420c4-83ab-492f-b58f-81f9feb106b5
2013-03-25 13:01:38 +00:00
Henrik Andersson
70d8c071c1 Add missing format string to snprintf's.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1703 423420c4-83ab-492f-b58f-81f9feb106b5
2013-03-22 12:38:19 +00:00
Henrik Andersson
d584b2fa3f Make sure that CredSSP is not used for smartcard SSO.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1697 423420c4-83ab-492f-b58f-81f9feb106b5
2013-03-18 11:56:37 +00:00
Henrik Andersson
c56a8c180c Changes the approach of how seamlessrdpshell is used and
breaks backward compabilities with old commandline arguments.

The -A argument does now require an string to seamlessrdp shell,
and argument -s has now a splitted meaning, in seamless mode it
does specify a application to start, and in standard mode it works
just like it worked before.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1692 423420c4-83ab-492f-b58f-81f9feb106b5
2013-01-25 14:10:11 +00:00
Henrik Andersson
6715013377 Missed to add 't' to getopt() arguments in previous commit r1689.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1690 423420c4-83ab-492f-b58f-81f9feb106b5
2013-01-21 13:33:41 +00:00
Henrik Andersson
be93803129 Intitial implementation of seamless connection sharing:
- Implementation of ctrl functionality were slaves can call
  a method into existing master process, more information is
  found in doc/ctrl.txt

- Implementation of new seamless SPAWN functionality so which
  is used by the ctrl to spawn processes in a seamless rdp session
  out of process.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1689 423420c4-83ab-492f-b58f-81f9feb106b5
2013-01-21 12:28:14 +00:00
Henrik Andersson
15e4518b13 Add support to use password argument as pin when logon
using smartcard.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1687 423420c4-83ab-492f-b58f-81f9feb106b5
2012-12-20 16:33:55 +00:00
Henrik Andersson
9f174ea864 Added check if socket is connected to prevent sending disconnect
sequence to a closed socket.

git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1681 423420c4-83ab-492f-b58f-81f9feb106b5
2012-11-22 13:38:35 +00:00
Henrik Andersson
0f5824d414 Rename of internal ssl_ wrapper functions/defines to
rdssl_ to prevent nameclashing with openssl library now
when we link against ssl library.

git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1665 423420c4-83ab-492f-b58f-81f9feb106b5
2012-07-02 11:36:39 +00:00
Henrik Andersson
67e0c58394 Use sizeof() to prevent mixups for previous commit.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1661 423420c4-83ab-492f-b58f-81f9feb106b5
2012-06-19 06:54:23 +00:00
Henrik Andersson
eed9bc7210 Fixes a bug were license filename differs from load/save license that
was introduced with commit 1648 and made rdesktop to always request
a license and never present the one stored.

Also fixed a potential issue with hash string length that did not
have room for an \0 after the hash stringify conversion.

git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1660 423420c4-83ab-492f-b58f-81f9feb106b5
2012-06-19 06:01:10 +00:00
Henrik Andersson
c44025aa18 Added support for protocol negotiation, this is a part of
adding Enhanced RDP Security support to rdesktop and brings
support for TLSv1 tunnel functionality.

git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1659 423420c4-83ab-492f-b58f-81f9feb106b5
2012-06-15 05:16:20 +00:00
Henrik Andersson
cdce9aae75 Run indentation script.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1658 423420c4-83ab-492f-b58f-81f9feb106b5
2012-01-16 06:35:13 +00:00
Henrik Andersson
be90d40a34 Fixed issues with a too small buffer used for output of
sec_hash_sha1_16() which introduced crashes on solaris,
sha1 need 160bit output buffer.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1648 423420c4-83ab-492f-b58f-81f9feb106b5
2011-11-25 10:03:03 +00:00
Henrik Andersson
8a52bf3a9b - Change licensestore to XDG directory ~/.local/share/rdesktop/licenses
- Added helper functions for SHA1 hash to hash the hostname used for
  licenses filename to hide information of what host user X connects 
  from in a infrastructure with NFS mounted home directories.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1644 423420c4-83ab-492f-b58f-81f9feb106b5
2011-11-21 10:51:08 +00:00
Peter Åstrand
c5415ded44 Try to fix 3428380 - session redirection broken in 1.7.0. We must not
call sizeof or strlen on a new dynamically allocated string. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1639 423420c4-83ab-492f-b58f-81f9feb106b5
2011-10-26 10:53:39 +00:00
Peter Åstrand
da08af3c5a Update copyright year in usage string, add "et al.".
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1622 423420c4-83ab-492f-b58f-81f9feb106b5
2011-04-18 07:30:28 +00:00