Commit Graph

2019 Commits

Author SHA1 Message Date
Peter Åstrand
65af3d5826 Corrected last patch, which broke SeamlessRDP. We should update
g_sizeopt to 100%; not g_width. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1552 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-14 16:14:23 +00:00
Peter Åstrand
6b7a66eebf We have been handling the special "relative" session sizes (workarea
and percent of screen) by abusing the g_width variable. However, this
is only works once, since g_width in this case is calculated using
itself. This will not work if we want to support xrandr. Besides, it's
quite ugly.

The patch changes this so that a separate variable, g_sizeopt, is used. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1551 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-14 15:53:24 +00:00
Peter Åstrand
38e38e90a0 Applied:
[PATCH] _NET_WORKAREA is interpreted wrong on 64-bit machines (-g workarea)



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1550 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-14 15:21:45 +00:00
Peter Åstrand
35404b22a3 Update the license for uiports/vnc to GPLv3.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1549 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-14 11:48:12 +00:00
Peter Åstrand
28ba7a082a g_wnd is not a pointer. Use 0 instead of NULL to avoid warnings.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1548 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-13 16:22:35 +00:00
Peter Åstrand
5b75525080 Re-wrote top main loop. The patch for session directory / load
balancing redirection made it *way* too complicated. We shouldn't
really need two extra state variables in addition to g_redirect. The
current approach also does not support future features such as
automatic reconnection in case of network problems. 

The new loop should be functionally equivalent to the previous one,
though it hasn't yet been tested with a load balancing server.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1547 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-13 16:07:29 +00:00
Peter Åstrand
9a926834ff Improve robustness: Make sure we don't act on window events for
windows that no longer exists. (This shouldn't happen with the current
code base, but will be a problem when multiple main windows and
created and destroyed through the process lifetime.)



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1546 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-13 14:53:43 +00:00
Peter Åstrand
ea2bdbc96b This patch is a re-work of patch r1538. One one hand, the plain old
behaviour of setting the session size in ui_init is not going to work,
due to xrandr, as pointed out in r1538. However, the approach
implemented in this revision doesn't work either: When the window is
created before the connection, this means that as soon as X11 events
are recieved, this is going to trigger RDP transmissions. For example,
a call to reset_modifiers_keys. But if the RDP connection is not
ready, the WTS is not prepared to handle such data. We must wait with,
for example, keyboard input until the connection is READY. OTOH, we
can't just ignore those X11 events; that might lead to that we are not
sending information that we need to send. 

So, it is actually better to wait with creating the window until we
have been connected. An additional advantage of this is that for the
load balancing / session directory case, there's no risk of confusion
of which RDP connection we are actually sending data to. 

The previous behaviour of creating the window after we have been
connected has been restored.

Since we still need to set connection data (currently screen size) on
a per connection basis, we need to create a new UI function for this.

Non-X11 backends need to implement this new function. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1545 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-13 13:51:06 +00:00
Peter Åstrand
f284a915ad Include set_keypress_keysym and reset_keypress_keysym to avoid gcc
warnings when building xwin.c. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1544 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 15:22:33 +00:00
Peter Åstrand
8c645ed401 Avoid gcc warning when using DEBUG; RD_HBITMAP is really a pointer.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1543 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 15:19:00 +00:00
Peter Åstrand
add482fcef Avoid gcc warning when using DEBUG; RD_HBITMAP is really a pointer.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1542 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 15:16:31 +00:00
Peter Åstrand
0983e771c8 Only try to use automatic reconnect if we have earlier recieved the
reconnect random. It seems to work anyway, but let's take care.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1541 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 15:00:49 +00:00
Peter Åstrand
46499078e1 Need to include ssl.h now that we are using ssl_hmac_md5.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1540 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 14:52:04 +00:00
Peter Åstrand
1b4c36a45f Implemented support for "Client Auto-Reconnect". This means that the
client can re-connect using a cookie, instead of going through the
normal authentication. This patch saves those cookies, and uses them
during logon. 

Note that this feature is currently unused. It remains to add support
for, say, detecting when the TCP connection has gone done and restart
a new one. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1539 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 10:34:38 +00:00
Peter Åstrand
d0327a9989 Moved code that determines desktop size from ui_init to
ui_create_window. ui_init is only called once during the execution,
but the size of the screen can change, for example, when resizing
using Xrandr. 

Note however that this also means that ui_create_window must be called
before rdp_connect. rdesktop.c has been modified accordingly. One
additional advantage is that you will get a window during the
connection phase, which gives the user better feedback in case the
connection takes time. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1538 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 10:19:35 +00:00
Peter Åstrand
adbb524e13 The background_pixel was specified twice, both as black and
white. Leave it as black. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1537 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 09:58:16 +00:00
Peter Åstrand
281d7c9f06 Changed license to GPLv3
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1534 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 08:31:06 +00:00
Peter Åstrand
91f3b6151f Changed style of copyright header to match the other files
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1533 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 08:06:15 +00:00
Peter Åstrand
5dbe5f0a05 Corrected license header
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1532 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 08:03:31 +00:00
Peter Åstrand
4c6424c1d4 Commented DaylightBias and clientSessionId fields.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1531 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 07:50:36 +00:00
Peter Åstrand
dddbfd93d8 Added comments about the TS_EXTENDED_INFO_PACKET variables.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1530 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-11 13:11:19 +00:00
Peter Åstrand
2a4f8578ac Reverted last patch; by mistake
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1529 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-07 20:12:04 +00:00
Peter Åstrand
440542c535 Elminate code duplication in rdp_reconnect and sec_connect.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1528 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-07 20:01:58 +00:00
Peter Åstrand
cf715c225c Indented on Fedora 11
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1527 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-07 18:52:26 +00:00
Peter Åstrand
d00373436a Avoid code duplication in iso_connect/iso_reconnect.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1526 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-07 18:42:47 +00:00
Peter Åstrand
a410341c11 Indented on Fedora 11
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1525 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-07 18:39:20 +00:00
Peter Åstrand
775715848c Avoid code duplication in mcs_connect/mcs_reconnect.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1524 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-07 18:31:16 +00:00
Peter Åstrand
1f3d7e61bc Document XP/domain return code problem.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1523 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-04 09:40:55 +00:00
Jay Sorg
c0197b7be2 Fix annoying problem where screen doesn't update until you move the mouse, caused by xwin.c revision 886
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1521 423420c4-83ab-492f-b58f-81f9feb106b5
2009-10-25 23:37:26 +00:00
Jay Sorg
fdcd8d7591 added new pointers
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1520 423420c4-83ab-492f-b58f-81f9feb106b5
2009-10-25 21:36:17 +00:00
Jay Sorg
6bc8c23da3 send the correct num_caps in rdp_send_confirm_active, re-enable glyph cache
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1519 423420c4-83ab-492f-b58f-81f9feb106b5
2009-10-19 23:02:52 +00:00
Peter Åstrand
bbeb187681 When modifiers are used and a key is released, the generated keysym
might be different from the one generated when the key was
pressed. This can happen if the user physically releases the modifier
key before the symbol key. It can also happen with VNC servers such as
Xvnc, since it only "fakes" the correct modifiers during key
presses. So, we must remember which keysym that was used during the
key press, and use the same on release, otherwise keys such as the
Windows key can be stuck activated. 



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1512 423420c4-83ab-492f-b58f-81f9feb106b5
2009-09-17 13:52:04 +00:00
Peter Åstrand
ecd9eeeaa6 Added hint of how to test egrave sequence.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1511 423420c4-83ab-492f-b58f-81f9feb106b5
2009-09-17 12:42:36 +00:00
Peter Åstrand
058ee33be3 Clean up and document the return values. Trying to solve a number of issues:
* The current return values have been selected pretty much without any
thought. Basically, the value 1 is used for all different kinds of
errors, except for a corner case where the server doesn't send a
RDP_PDU_DEACTIVATE in combination with a few special "reasons", where
the value 2 is used instead.

* rdesktop will currently also return with 2 if the user is closing
the rdesktop window, the same error as many other fatal errors, which
is somewhat strange.

* The main principle of my patch is to utilize more of the available
256 return codes. We are currently only using 3 values out of
256. This is bad; rdesktop should expose more information to the
caller about error conditions if it can.

Besides using the standardized exit codes for generic errors such as
EX_USAGE for command line usage errors, I've also exposed the
"extended disconnect reasons" from RDP. This allows for, for example,
to be able to distinguish between a logoff and a disconnect.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1510 423420c4-83ab-492f-b58f-81f9feb106b5
2009-09-02 13:03:43 +00:00
Peter Åstrand
5c67800d15 Indent fixes; ran indent-all with modern indent (F11)
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1509 423420c4-83ab-492f-b58f-81f9feb106b5
2009-08-27 08:35:48 +00:00
Peter Åstrand
ea46f1729d process_data_pdu never returns True nowadays, so the comment about the
disc variable is incorrect. Removed the variable, since it's always
False.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1508 423420c4-83ab-492f-b58f-81f9feb106b5
2009-08-27 07:30:32 +00:00
Peter Åstrand
55eaf2a098 Fix build with DEBUG: depth variable is no longer.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1507 423420c4-83ab-492f-b58f-81f9feb106b5
2009-08-26 15:20:32 +00:00
Peter Åstrand
be2812888f Applied patch by Enrico Scholz:
autoconf: renamed socklen_t_equiv to socklen_t_ac_equiv - ID: 2624071



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1506 423420c4-83ab-492f-b58f-81f9feb106b5
2009-08-26 12:34:04 +00:00
Peter Åstrand
e5e7b5572f Minor changes to make this README reStructured text.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1505 423420c4-83ab-492f-b58f-81f9feb106b5
2009-05-15 11:41:40 +00:00
Peter Åstrand
32e66f94b8 Removed empty script sections
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1485 423420c4-83ab-492f-b58f-81f9feb106b5
2008-12-12 13:49:01 +00:00
Peter Åstrand
c7feab2840 Ran indent-all
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1484 423420c4-83ab-492f-b58f-81f9feb106b5
2008-11-25 08:05:25 +00:00
Jay Sorg
a42c5895f6 added brushtest
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1483 423420c4-83ab-492f-b58f-81f9feb106b5
2008-11-02 03:55:00 +00:00
Jay Sorg
c3dc159869 brush cache for > 2 color brushes
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1482 423420c4-83ab-492f-b58f-81f9feb106b5
2008-11-01 02:37:10 +00:00
Peter Åstrand
b64678c9ee Temporarily disabled the recently added brush cache feature, due to
bug 2167833.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1481 423420c4-83ab-492f-b58f-81f9feb106b5
2008-10-20 07:16:43 +00:00
Peter Åstrand
d87e27483f Reworked device opening, only open the device with the access that we
currently needs. Avoids transmitting recording data on playback with padsp.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1480 423420c4-83ab-492f-b58f-81f9feb106b5
2008-10-02 18:21:58 +00:00
Peter Åstrand
edbae085f1 Everything except oss_register can be static
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1479 423420c4-83ab-492f-b58f-81f9feb106b5
2008-10-02 09:48:20 +00:00
Peter Åstrand
27388283ad Removed the hardcoded limit of the username length.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1478 423420c4-83ab-492f-b58f-81f9feb106b5
2008-09-26 11:40:54 +00:00
Peter Åstrand
bf4c26c110 Two minor fixes to avoid compiler warnings.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1477 423420c4-83ab-492f-b58f-81f9feb106b5
2008-09-26 11:32:43 +00:00
Jay Sorg
c9a4156554 update the copyright year
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1476 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 06:01:18 +00:00
Jay Sorg
f306257aa4 ran indent and removed some spaces at EOL
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1475 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 03:55:52 +00:00