Commit Graph

49 Commits

Author SHA1 Message Date
Karl Mikaelsson
5351182410 Fix problems with transferring large files
The entire device redirection framework is documented to use 64-bit
offsets rather than 32-bit offsets. This should fix any problems
transfering large files with rdesktop.

Co-Authored-By: gpatel-fr <44170243+gpatel-fr@users.noreply.github.com>
2019-01-31 10:51:19 +01:00
Karl Mikaelsson
4e6787c889 Add types and stream infrastructure for 64-bit integers
In preparation for reading 64-bit file offsets.
2019-01-29 16:41:39 +01:00
Henrik Andersson
4dca546d04 Malicious RDP server security fixes
This commit includes fixes for a set of 21 vulnerabilities in
rdesktop when a malicious RDP server is used.

All vulnerabilities was identified and reported by Eyal Itkin.

 * Add rdp_protocol_error function that is used in several fixes
 * Refactor of process_bitmap_updates
 * Fix possible integer overflow in s_check_rem() on 32bit arch
 * Fix memory corruption in process_bitmap_data - CVE-2018-8794
 * Fix remote code execution in process_bitmap_data - CVE-2018-8795
 * Fix remote code execution in process_plane - CVE-2018-8797
 * Fix Denial of Service in mcs_recv_connect_response - CVE-2018-20175
 * Fix Denial of Service in mcs_parse_domain_params - CVE-2018-20175
 * Fix Denial of Service in sec_parse_crypt_info - CVE-2018-20176
 * Fix Denial of Service in sec_recv - CVE-2018-20176
 * Fix minor information leak in rdpdr_process - CVE-2018-8791
 * Fix Denial of Service in cssp_read_tsrequest - CVE-2018-8792
 * Fix remote code execution in cssp_read_tsrequest - CVE-2018-8793
 * Fix Denial of Service in process_bitmap_data - CVE-2018-8796
 * Fix minor information leak in rdpsnd_process_ping - CVE-2018-8798
 * Fix Denial of Service in process_secondary_order - CVE-2018-8799
 * Fix remote code execution in in ui_clip_handle_data - CVE-2018-8800
 * Fix major information leak in ui_clip_handle_data - CVE-2018-20174
 * Fix memory corruption in rdp_in_unistr - CVE-2018-20177
 * Fix Denial of Service in process_demand_active - CVE-2018-20178
 * Fix remote code execution in lspci_process - CVE-2018-20179
 * Fix remote code execution in rdpsnddbg_process - CVE-2018-20180
 * Fix remote code execution in seamless_process - CVE-2018-20181
 * Fix remote code execution in seamless_process_line - CVE-2018-20182
2019-01-16 12:28:44 +01:00
Henrik Andersson
c16b74a974 Run indent-all.sh script on source 2018-10-29 15:53:57 +01:00
Cendio
ba41f749c6 Refactor g_sizeopt into an enumeration for clarity
Signed-off-by: Henrik Andersson <hean01@cendio.com>
Signed-off-by: Karl Mikaelsson <derfian@cendio.se>
2018-01-11 15:10:05 +01:00
Cendio
d2cbbd46ce Move dvc_hdr_t into dvc.c 2017-11-09 17:03:59 +01:00
Cendio
2f03f65efe Add Dynamic Virtual Channels and basic RDPEDISP support
Fix issue #192

Signed-off-by: Henrik Andersson <hean01@cendio.com>
Signed-off-by: Karl Mikaelsson <derfian@cendio.se>
2017-11-09 15:39:39 +01:00
Karl Mikaelsson
90ea473750 Send longer drive names for redirected drives
Store the full drive name in a new disk-specific pdevice_data
struct. Bump Drive Redirection version to 02, and send the full name
as part of the Device Announcement message.
2017-01-25 13:27:01 +01:00
Henrik Andersson
cb06fe1863 Applied slightly modified patch #220 that fixes
hash collisions with keysyms.



git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1802 423420c4-83ab-492f-b58f-81f9feb106b5
2014-05-20 10:43:03 +00:00
Henrik Andersson
c44025aa18 Added support for protocol negotiation, this is a part of
adding Enhanced RDP Security support to rdesktop and brings
support for TLSv1 tunnel functionality.

git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1659 423420c4-83ab-492f-b58f-81f9feb106b5
2012-06-15 05:16:20 +00:00
Peter Åstrand
281d7c9f06 Changed license to GPLv3
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1534 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 08:31:06 +00:00
Peter Åstrand
c7feab2840 Ran indent-all
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1484 423420c4-83ab-492f-b58f-81f9feb106b5
2008-11-25 08:05:25 +00:00
Jay Sorg
c3dc159869 brush cache for > 2 color brushes
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1482 423420c4-83ab-492f-b58f-81f9feb106b5
2008-11-01 02:37:10 +00:00
Jay Sorg
88855ddcbf update the copyright year
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1474 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 03:51:23 +00:00
Jay Sorg
b59c4b92a6 added brush cache
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1473 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 03:35:24 +00:00
Jay Sorg
6091381a81 prefix BOOL with RD_
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1371 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-08 04:47:06 +00:00
Michael Gernoth
510afcca69 ignore PCSCs idea of BOOL
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1367 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-04 23:19:54 +00:00
Jay Sorg
797df4fa02 copyright year update
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1364 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-04 05:39:39 +00:00
Jay Sorg
b670bdacfa RD_ prefix and win32 compatibility for core files
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1363 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-04 04:55:56 +00:00
Michael Gernoth
ae67d3e759 Add smartcard support for mac os x
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1310 423420c4-83ab-492f-b58f-81f9feb106b5
2006-11-01 21:23:08 +00:00
Michael Gernoth
f37c871e8b Smartcard support by Alexi Volkov <alexi@pravex.kiev.ua> and additional
patches for smartcard-support by Jennings Jared <jared.jennings.ctr@eglin.af.mil>


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1308 423420c4-83ab-492f-b58f-81f9feb106b5
2006-11-01 20:52:01 +00:00
Peter Åstrand
7b55ece8e4 Added support for a new virtual channel, lspci, which makes it
possible for the remote RDP server to enumerate the local PCI devices.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1052 423420c4-83ab-492f-b58f-81f9feb106b5
2006-03-02 15:22:25 +00:00
Michael Gernoth
7ffe422a52 Slightly modified long filenames-patch from Alex Miller <asm at asm.kiev.ua>
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@977 423420c4-83ab-492f-b58f-81f9feb106b5
2005-08-15 11:44:35 +00:00
Peter Åstrand
c04f1dc310 Implemented support for keyboard "sequences", which makes it possible to send multiple scancodes to the RDP server in response to one X11 keyboard event.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@948 423420c4-83ab-492f-b58f-81f9feb106b5
2005-08-02 15:07:35 +00:00
Jeroen Meijer
f589939e23 Add support for ellipse and polygon orders
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@830 423420c4-83ab-492f-b58f-81f9feb106b5
2005-03-08 00:43:10 +00:00
Jeroen Meijer
a78d2b3ec9 optimise persistent bitmap caching and hopefully improve the terminology
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@829 423420c4-83ab-492f-b58f-81f9feb106b5
2005-03-08 00:23:02 +00:00
Michael Gernoth
ec643e4718 bump version to 1.4.0
change year in files
add missing docu for updated commandline-flags
update changelog


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@827 423420c4-83ab-492f-b58f-81f9feb106b5
2005-03-06 21:11:18 +00:00
Michael Gernoth
53eabea36f Big serial- and disk-redirection update from
Andreas Flick <Andreas.Flick@unicon-ka.de>


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@794 423420c4-83ab-492f-b58f-81f9feb106b5
2004-11-03 13:56:52 +00:00
Jay Sorg
c0651b51a1 change HANDLE to NTHANDLE to avoid conflics
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@775 423420c4-83ab-492f-b58f-81f9feb106b5
2004-10-02 01:30:33 +00:00
Jay Sorg
7f836f0384 added persistant bitmap chaching from Jeroen Meijer, slightly modified
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@724 423420c4-83ab-492f-b58f-81f9feb106b5
2004-06-27 17:51:54 +00:00
Peter Kallden
5db5d38a46 mppc like decompression for the rdp protocol. code not activated. rdp5 gets some extra opcodes, and the decompression seems to work fine. :\
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@682 423420c4-83ab-492f-b58f-81f9feb106b5
2004-04-27 12:55:33 +00:00
Peter Kallden
351edec7e5 move disk info define to types.h
extract aio remove
handle errors in aio read / write
function that checks if handle is ok - seems windows cant keep track of them huh
- volker milde


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@626 423420c4-83ab-492f-b58f-81f9feb106b5
2004-03-04 08:24:40 +00:00
Peter Åstrand
a9a863db41 Ran indent-all.sh
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@579 423420c4-83ab-492f-b58f-81f9feb106b5
2004-01-23 08:35:52 +00:00
Peter Kallden
a61eac7b19 redirection of disk, lptport, printer, comport.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@568 423420c4-83ab-492f-b58f-81f9feb106b5
2004-01-21 14:40:40 +00:00
Peter Åstrand
3a323bbcc1 Fixed indentation
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@498 423420c4-83ab-492f-b58f-81f9feb106b5
2003-10-15 14:01:32 +00:00
Michael Gernoth
9ba4716057 Fix format-detection by Robert Sanders
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@491 423420c4-83ab-492f-b58f-81f9feb106b5
2003-10-14 07:46:49 +00:00
Matt Chapman
d3e6c1a157 Preliminary sound support (PCM only).
Based on code from GuoJunBo <guojunbo@ict.ac.cn>


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@473 423420c4-83ab-492f-b58f-81f9feb106b5
2003-09-30 09:11:08 +00:00
Peter Åstrand
7ff54cdd90 Indent fixes
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@434 423420c4-83ab-492f-b58f-81f9feb106b5
2003-07-09 09:18:20 +00:00
Matt Chapman
5b9286e6ea Commit of work in progress on channels (so that other people can hack on
RDPSND), in particular:
* channel layer takes care of virtual channel header
* split X dependent parts out of CLIPRDR, simplified IPC implementation
* initial RDPDR implementation


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@431 423420c4-83ab-492f-b58f-81f9feb106b5
2003-07-01 09:31:25 +00:00
Erik Forsberg
87a76f5924 Definition of cliprdr_dataformat.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@412 423420c4-83ab-492f-b58f-81f9feb106b5
2003-06-06 11:08:15 +00:00
Jay Sorg
679261b7fc changed all order vars that go through rdp_in_coord to sint16
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@374 423420c4-83ab-492f-b58f-81f9feb106b5
2003-05-16 21:55:14 +00:00
Jay Sorg
4b26f4fc6b 16bit
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@308 423420c4-83ab-492f-b58f-81f9feb106b5
2003-02-04 05:32:13 +00:00
Matt Chapman
90a283925e Add some signed types and use them in the places we have silly casts now.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@298 423420c4-83ab-492f-b58f-81f9feb106b5
2003-01-30 11:15:00 +00:00
Matt Chapman
b120a50f44 Update copyright dates on all files that have changed.
Bump version to 1.2-cvs.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@206 423420c4-83ab-492f-b58f-81f9feb106b5
2002-09-26 14:26:46 +00:00
Peter Åstrand
2dd151bd20 Merged new keysym-based keyboard handling (from alt. CVS repos)
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@65 423420c4-83ab-492f-b58f-81f9feb106b5
2002-07-18 18:28:12 +00:00
Peter Åstrand
0685b1b65c Fixed indentation with indent
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@63 423420c4-83ab-492f-b58f-81f9feb106b5
2002-07-18 16:38:31 +00:00
Matt Chapman
b5082af223 Merges from pl19-6-5.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@27 423420c4-83ab-492f-b58f-81f9feb106b5
2001-06-20 13:54:48 +00:00
Matt Chapman
71830eeb65 Respect x offset in font information.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@19 423420c4-83ab-492f-b58f-81f9feb106b5
2000-10-16 07:37:52 +00:00
Matt Chapman
cd9b5a8761 Major commit of work from laptop - done in various free moments.
Implemented encryption layer and some basic licensing negotiation.
Reorganised code somewhat. While this is not quite as clean, it is
a lot faster - our parser speed was becoming a bottle-neck.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@9 423420c4-83ab-492f-b58f-81f9feb106b5
2000-08-15 10:23:24 +00:00