Commit Graph

37 Commits

Author SHA1 Message Date
Pierre Ossman
489c43f382 Return STREAM objects from data generating functions
Use a consistent style of returning a new STREAM object from functions
that output data, rather than requiring an existing structure to be
passed in. This generally makes the memory management more straight
forward and allows us to do more proper bounds checking of everything.

This also adds some new STREAM macros to make it easier to manage
them without poking around in the internal structure.
2019-05-06 14:33:11 +02:00
René Genz
9e99dd52d6 Fix minor spelling mistakes 2017-11-02 01:01:44 +01:00
Henrik Andersson
896a923f55 Markup unused parameters 2017-10-20 11:05:52 +02:00
Henrik Andersson
87d8d123b8 Rework the logging system
This commit will add a logging system to solve the problem that
one actually need to recompile rdesktop from source to enable
different debug logging.

- Same logging api  for all kind of logging and messages to
   end user.

- Adding -v for verbose output when running rdesktop.

- All messages are logged into a subject and with a type, eg:

     logger(Keyboard, Notice, "Autos-electing %s based on locale.", locale);

- Debug logging is enabled trough a environment variable RDEKSTOP_DEBUG,
  which specifies subjects of interest, comma separated. There is a special
  subject named All which includes all subject for debug loggin. There is also
  a simple logic opeartor '!' = NOT which can be used in combination like:

    RDESKTOP_DEBUG=All,!Graphics,!Sound

  Which would give debug log output for All subject except Graphics and Sound.
2017-01-26 14:19:40 +01:00
Peter Åstrand
704ff6a3be Minor warning message fix.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1737 423420c4-83ab-492f-b58f-81f9feb106b5
2013-09-16 12:45:24 +00:00
Peter Åstrand
b47063c74f Consistent formatting of emails in copyright headers.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1616 423420c4-83ab-492f-b58f-81f9feb106b5
2011-04-13 11:28:19 +00:00
Peter Åstrand
5fe3caff71 A few copyright tweaks: added email, years, organization.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1613 423420c4-83ab-492f-b58f-81f9feb106b5
2011-04-13 10:51:50 +00:00
Peter Åstrand
281d7c9f06 Changed license to GPLv3
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/rdesktop/trunk@1534 423420c4-83ab-492f-b58f-81f9feb106b5
2010-01-12 08:31:06 +00:00
Jay Sorg
88855ddcbf update the copyright year
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1474 423420c4-83ab-492f-b58f-81f9feb106b5
2008-07-11 03:51:23 +00:00
Pierre Ossman
adb6acbbee Be a bit more noisy if someone is feeding bad data.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1430 423420c4-83ab-492f-b58f-81f9feb106b5
2008-02-08 10:35:16 +00:00
Jay Sorg
6f014c836a remove g++ errors and warnings
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1393 423420c4-83ab-492f-b58f-81f9feb106b5
2007-02-10 07:12:36 +00:00
Jay Sorg
6091381a81 prefix BOOL with RD_
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1371 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-08 04:47:06 +00:00
Jay Sorg
797df4fa02 copyright year update
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1364 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-04 05:39:39 +00:00
Jay Sorg
b670bdacfa RD_ prefix and win32 compatibility for core files
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1363 423420c4-83ab-492f-b58f-81f9feb106b5
2007-01-04 04:55:56 +00:00
Pierre Ossman
10bad3c82d New packet based parser for the rdpsnd protocol.
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1341 423420c4-83ab-492f-b58f-81f9feb106b5
2006-12-06 13:29:42 +00:00
Peter Åstrand
bcec43cb63 Indent fix
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1304 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-27 12:58:13 +00:00
Michael Gernoth
d5725f46d9 small fix to the (still disabled) linear resampler
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1302 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-26 22:26:16 +00:00
Michael Gernoth
3701080708 add (disabled) real linear resampler. quality is currently not as good
as previous simpler implementation, but will be improved


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1291 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-02 08:01:24 +00:00
Michael Gernoth
7b6705553d improve sound quality a bit again
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1290 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 23:42:14 +00:00
Michael Gernoth
101a5557fa convert between different numbers of input and output channels
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1287 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 21:46:38 +00:00
Michael Gernoth
65b4b60bd5 simplify resampling
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1286 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 19:05:30 +00:00
Michael Gernoth
076221eb15 add missing include
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1284 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 18:22:05 +00:00
Michael Gernoth
cd2ae82e7c sound quality fixes for resampling
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1283 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 17:51:51 +00:00
Michael Gernoth
a8f9e84598 add simple linear resampling implementation to be used when libsamplerate
is not available


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1282 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 17:23:30 +00:00
Michael Gernoth
de56acd493 fix conversion between arbitrary samplerates
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1281 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 15:07:55 +00:00
Michael Gernoth
deace67d29 make it possible to resample 8bit<->16bit soundstreams
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1280 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 14:31:09 +00:00
Michael Gernoth
e82b81576b make it possible for the driver to switch resampling on and off
dynamically. this will be needed for the OSS driver.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1278 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 14:03:43 +00:00
Michael Gernoth
8129a2d373 use libsamplerate for resampling when available
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1277 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 13:57:34 +00:00
Michael Gernoth
8f8ea57234 only resample when there is need
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1276 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 12:26:01 +00:00
Michael Gernoth
b7b4327927 move simple resample algorithm from rdpsnd_libao.c to rdpsnd_dsp.c to
provide a base for a better resample-algorithm


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1275 423420c4-83ab-492f-b58f-81f9feb106b5
2006-10-01 12:16:50 +00:00
Michael Gernoth
1ee09f6688 replace constants with their define
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1269 423420c4-83ab-492f-b58f-81f9feb106b5
2006-09-18 10:20:02 +00:00
Michael Gernoth
c4b90c2072 Recover missing 4 bytes in audio-stream thanks to a hint in an old
email from Robert Sanders <esquimaux73@mailblocks.com>:

I found a trick that seems to solve this.  Basically, I copy the last
4 bytes of the RDPSND_WRITE command that precedes the sample data.
It's not being used by anything else.  I can't tell whether this is
some trick to "pre-load" the sample buffer, or some error in
rdesktop's interpretation of the RDP sound protocol.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1264 423420c4-83ab-492f-b58f-81f9feb106b5
2006-09-17 20:06:37 +00:00
Michael Gernoth
4c83a35b48 call rdpsnd_dsp_process from a better place
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1262 423420c4-83ab-492f-b58f-81f9feb106b5
2006-09-17 18:08:51 +00:00
Michael Gernoth
45cc3f12f4 use correct types in rdpsnd_dsp_softvol
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1261 423420c4-83ab-492f-b58f-81f9feb106b5
2006-09-17 15:49:14 +00:00
Michael Gernoth
7ef82f75c7 unify audio-byteswapping as a dsp-function
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1259 423420c4-83ab-492f-b58f-81f9feb106b5
2006-09-17 15:25:10 +00:00
Michael Gernoth
8d590a7ba3 softvol only needs one buffer
git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1258 423420c4-83ab-492f-b58f-81f9feb106b5
2006-09-17 15:08:48 +00:00
Michael Gernoth
76459e4005 add software volume control (currently only for libao but will be
used for alsa, too)


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1257 423420c4-83ab-492f-b58f-81f9feb106b5
2006-09-17 14:41:16 +00:00