kekePower/rdesktop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

In translate24to32, only read 3 bytes from data buffer. If we are

Browse Source 
reading 4 bytes, we are reading beyond the buffer. Fixes valgrind
warnings.


git-svn-id: svn://svn.code.sf.net/p/rdesktop/code/trunk/rdesktop@1039 423420c4-83ab-492f-b58f-81f9feb106b5
This commit is contained in:
Peter Åstrand 2006-01-24 12:24:40 +00:00
parent 4cd9674c78
commit d8a0e374a6
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
xwin.c
View File

@ -802,7 +802,8 @@ translate24to32(const uint8 * data, uint8 * out, uint8 * end)
#else #else
REPEAT4 REPEAT4
( (
*((uint32 *) out) = *((uint32 *) data); /* Only read 3 bytes. Reading 4 bytes means reading beyound buffer. */
*((uint32 *) out) = *((uint16 *) data) + (*((uint8 *) data + 2) << 16);
out += 4; out += 4;
data += 3; data += 3;
) )