From cf95138c9b87e4e61a9f1b99841402cff4d1a99b Mon Sep 17 00:00:00 2001 From: Pierre Ossman Date: Wed, 10 Apr 2019 11:11:14 +0200 Subject: [PATCH] Don't use strncpy() when not needed It upsets the compiler warnings when you do strncpy() with the source buffer size as the limit. It is also unnecessary to use strncpy() here as we just allocated a buffer guaranteed to be large enough. --- rdesktop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rdesktop.c b/rdesktop.c index a32362c..ce4acdc 100644 --- a/rdesktop.c +++ b/rdesktop.c @@ -836,7 +836,7 @@ main(int argc, char *argv[]) case 'u': g_username = (char *) xmalloc(strlen(optarg) + 1); - STRNCPY(g_username, optarg, strlen(optarg) + 1); + strcpy(g_username, optarg); username_option = 1; break; @@ -1355,7 +1355,7 @@ main(int argc, char *argv[]) STRNCPY(domain, g_redirect_domain, sizeof(domain)); xfree(g_username); g_username = (char *) xmalloc(strlen(g_redirect_username) + 1); - STRNCPY(g_username, g_redirect_username, strlen(g_redirect_username) + 1); + strcpy(g_username, g_redirect_username); STRNCPY(server, g_redirect_server, sizeof(server)); flags |= RDP_INFO_AUTOLOGON;